Reported by Keyop (upon being auto-disconnected overnight):
!ERROR 9 (Bad file descriptor) in data_ovl.cpp line 47 (putmsgptrs) writing
"message pointers" access=0

Unfortunately, the way putmsgptrs() was written, we couldn't tell if this was
an open (data/user/*.subs file) issue or a writing issue.

So create putmsgptrs_fp() and use that from sbbs_t::putmsgptrs(), so we can
log a different error (with more accurate details) if it's a file-open failure
versues a file-write failure.

Fix #782 - websocketservice.js garbles input on Banana Pi running Armbian

Closes #782

See merge request !458

The "from_ip" header field of QWK messages is checked against blocked IP
addresses, but was only checking against IP addresses from ip.can, not any
addresses listed in ip-silent.can. These 2 list files are now merged together
for the purposes of filtering during QWK/REP packet import.

Add '-v' (increase verbosity) option, used to display msg dates and timezones
... when using the the 'l' (list messages) command (to view post date/time).
Use '-vv' or '-v -v' to see timezones of messages.

The -v option is now also applicable to the 'v' (view) messages command (now
redundant with the 'V' command).

Features as requested by Nelgin as part of issue #786.

Removed day-of-week from date/times displayed. We don't need that level of
user-friendliness with this tool.
However, we are also displaying 12h/am/pm times. Some sysops probably would
prefer 24hour time, so that should be considered at some point.

... related to issue #786.

Also, don't check for a message-ID if the message-type does not match the
expected message type ("type mismatch").

1. When a 0-length bundle file was encountered or an unpacking error occurred,
   any remaining bundles for the current search day-of-week (e.g. *.SU*) would
   be skipped/ignored. This bug (issue #764, regarding the 0-length file part),
   is fixed by not incrementing the day-of-week index in the main loop, but
   rather only incremeting the index when all bundles for the current
   day-of-week have been processed.
2. The age calculation for 0-byte/length bundle files was incorrect, so all
   0-length  bundle files would always be considered "less than 24-hours old"
   (and thus, never auto-deleted).
   This exacerbated the problem of issue #764 since it would persist until the
   0-length files were manually deleted. Fixed the file age calculation and
   now logging the date/timestamp of the 0-length file as well.
3. Don't do the switch/case/sprintf dance when we're not re-running a glob()
   search.
4. Replace the switch/case statement with an array of week day names/patterns.
5. Ignore (with a warning log message) any sub-directories of the inbound
   directory that happen to match the bundle file search pattern.
6. Use better variable naming.
7. Refer to files with a length of 0 as "0-length" instead of "0-byte" in log
   messages.

I think this might fix issue #781. I suspect that SBBS (the MQTT client) is
being disconnected by the server ("due to protocol error") *after* the
call to mosquitto_connect_bind() is successful. We don't have any correponding
log output for this case, but at least we can track the connection status
accurately using the Mosquitto client callbacks and not try to publish when
we're not connected.

For cases where an mqtt struct is shared between threads without concurrency
control. I'm making this improvement in light of research into issue #781,
though I don't expect this change to fix the reported issue.

The reported error seems to come from the event thread (publishing node
status upon starting to run the "DAILY" event) when a broker connection was
not successful, however the reporter (Nelgin) may not have had debug-level
logging turned on, so didn't capture the successful broker-connect log
message. I think the broker connection *was* successful and perhaps then
terminated by the broker ("due to protocol error"?).

Fix issue #785

It appears I had the idea to make the CantPost text.dat string a format string
before, but never quite finished that change (e.g. made the change to
email.cpp and text.dat too).

There's a whole lotta calls to sprintf() then logline() that could be reduced
with this function.

For regular user QWK Relpy packet uploads only, if no timezone is specified
(e.g. via @TZ kludge or HEADERS.DAT), then over-ride the message's "posted"
date/time with the current date/time since we're going to set the message's
timezone to the BBS's local timezone as well.

This is a fix for issue #783 reported by Chris Jacobs.

If/when we support user-specified timezones, then this likely would be a
place where we'd want to use the user's timezone.

From todo list on Vertrauen, not in GitLab (shrug)

dd_lightbar_menu.js: Fix for out-of-bounds row updates when updating the scrollbar in DDLightbarMenu_UpdateScrollbar()

See merge request !457

Eric Oulashin authored 6 months ago and Rob Swindell committed 6 months ago

dd_lightbar_menu.js: Fix for out-of-bounds row updates when updating the scrollbar in DDLightbarMenu_UpdateScrollbar()

DDMsgReader: Fix for saving an ANSI message to the local BBS PC (undeclared variable error). Found by Amessyroom

See merge request !456

Eric Oulashin authored 6 months ago and Rob Swindell committed 6 months ago

DDMsgReader: Fix for saving an ANSI message to the local BBS PC (undeclared variable error). Found by Amessyroom

ddfilelister: "Edit" item text on the bottom horizontal menu for traditional/non-lightbar interface

See merge request !454

When no files with extensions are found, though they matched the glob()
pattern, a NULL pointer deref would result (segfault).

This could happen if the only files matching the pattern had no extenions or
were directories (not files).

Fix for issue #779

... this was the cause of some observed unnecessarily high disk/file server
(Samba) utilization, as we call getnodedat() a lot. utime() opens and closes
the file, which was already open - and we're not modifying the file, so
updating the 'modification time' here is wrong anyway.

Disabling this 21-year old bit of logic resulted in a pretty dramatic
reduction in Samba (smbd) CPU utilization on Vertrauen.

If a BBS actually needes this hack (e.g. for NFS compatibility, as Deuce
eluded in the comment), they'd be better off just setting the "Keep Node File
Open" node setting (in SCFG->Nodes) to "No".

I'v been getting errors locking user.tab (for read) for a while (over samba),
so hopefully this helps. The lockuserdat() total timeout duration extends from
about 5 seconds to about 45 seconds (with an incremental back-off).

Implement the same lock-retry logic/limit in putuserdat().

... requested by someone in #synchronet

Apparently, Mike Dippel's actual FidoNet address is 3:712/1321.5

DDFileLister: Now supports editing file info (with the E key).

See merge request !453

At least 512 bytes per call.

Eliminates GCC warning about not checking return value of write/sendsocket()

Includes swindows with unborked home/end key handling in lightbar. Fixes problem reported by Nightfox.

browser. Should be feature-equivalent with the old one, though
the navigation is a bit different.

If you don't like it, dig the old one out of git and run it from
some other location.

This is a build of:
https://gitlab.synchro.net/echicken/nodelist-browser
and it will be maintained there for now. I'll try to remember to
update this copy as needed. Do not edit / commit changes to this
file; it's transpiled from TypeScript and not meant to be edited
by hand. Do not read this file if you value your sanity.

The expansion of LF to CRLF (with TG_EXPANDLF) is on receive.

For Nelgin