Previously, we only cleared hotspots when executing any external from the
external program section (doors menu). This means that invoking a script or
external program (e.g. via JS bbs.exec()) from anywhere else, any current
mouse hotspots would remain active. Disable those.

This fixes issue #758

The extra characters (comments) are ignored when parsing this particular file,
so though this is not how we normally add comments to .ini files, it still
works fine in this case.

Another legacy config file replaced with .ini file (for easier editing and
future extensibility).

No longer dynamically allocate scfg_t.colors (no need). There's really no
reason why this is still an array, but leave as is for now.

Also, I noticed JS console.color_list (also an array) is not enumerable
(or documented) - that should be fixed.

This was a loop-hole that caused Denn (OUTWEST) some confusion, those his
QWKnet account could post polls, it could not post messages due to having the
P-restriction.

Fixes error reported by Rowyn Sand (Ravne) with accepting a marriage
proposal (issue #757)

client_t.protocol is no longer a pointer.

Warnings reported by gcc (Debian 12.2.0-14) 12.2.0

... rather than calling textmode() after.

This solves the problem of black bars above and below the UIFC window in
echocfg and SCFG on ChromeOS, at least.

All keys are now in the root/global section and they are now:

video_mode (default: 42)
uifc_mode (default: 0)
ciolib_mode (default: 0)
scaling (default: 0)
lines (default: 25)
insert (default: false)
esc_delay (default: 25)

These global variables weren't actually used for any purpose.

If a sysop wants to override the default user interface/console I/O library
behavior of SCFG without using command-line arguments, they can create a
ctrl/scfg.ini file with the following optional [section] keys:

[uifc]
mode (advanced uses, e.g. disabling mouse support)
height (in lines)
insert (keyboard insert mode, not overwrite)
esc_delay (ESC-key delay)

[ciolib]
mode (advanced uses)
scaling (fractional values, e.g. 1.5, supported)
height (in pixels)
width (in pixels)

Command-line arguments take precedence over scfg.ini settings (if set).

The scfg.ini file is read *before* parsing command-line args, so if a ctrl
directory is specified on the command-line (e.g. rather than via environment
variable), the scfg.ini file won't be read from that specified location but
rather the default (/sbbs/ctrl) or the SBBSCTRL env var value.

Another attempt to make Nelgin happy and close out issue #749, though no, this
doesn't auto-save the current parameters (you'll have to create/edit the
scfg.ini file by hand).

Fix issue #754

SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is an object before using it.  Should help with #755.

See merge request !436

SlyEdit: In SlyEdit_Misc.js, check to see that xtrn_area.editor[user.editor] is an object before using it.  Should help with #755.

I'm not clear why Walnut Creek would list files (e.g. readme.txt) in these
lists of "directories", but don't create file areas for them. Less clean-up
required after import.

I usually use the hostname for the name of the dialing entry and got tired
of always having to type the hostname twice when creating a new entry.

If the name looks like a hostname or IP address (includes a dot but
no spaces) and the connection type is appropriate, make the name the
default string for the address (easily over-ridden if wrong, by just
typing the correct address). This time-saving feature doesn't work for
single-word hostnames (e.g. "localhost") or IPv6 addresses.

SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the 'to' name length in DCT mode.

See merge request !435

Eric Oulashin authored 10 months ago and Rob Swindell committed 10 months ago

SlyEdit: Don't line-wrap poll messages for quoting. Also, minor fix for the 'to' name length in DCT mode.

    Comparing an array to null is not useful: "client->protocol == NULL",
    since the test will always evaluate as true.

or will always evaluate as *false* (the array won't ever be NULL). <shrug>

getfname() just returns the last path element, so can't use that here.

The dirnum and subnum are used for the next/previous (left and right) arrow
nav through sub-boards and directories. For message groups or file libs that
are configured to auto-sort the sub-boards or directory list, when importing
an unsorted list, the dirnum and subnum values would then be wrong after the
qsort() at the end of the import thus making the left/right nav thing broken
(jump to other groups/libs and such).

This fixes that.

Could I have fixed this by passing an index value to the next/prev_dirnum()
and _subnum() functions and returning the next/previous index value instead of
relying on the subnum/dirnum elemment to be correct? Maybe. <shrug>
Do I like second guessing myself? Not really.

The fallback to external extractors/archivers didn't really work unless a
libarchive function (called from extract_files_from_archive) actually failed
and the return value was < 0. A return value of 0 would mean the external
file extractor would never be used.

This was discovered when trying to import DIZ from old ZIP files (from 1992)
that used "Implode" compression method for the FILE_ID.DIZ, which is a
compression method *not* supported by libarchive. This is a reason why sysops
might want to leave Info-zip's 'unzip' as a configured Extractable File Type
handler (in SCFG) for 'zip' files.

Don't call the external archiver 3 times for the 3 DIZ filenames supported.
Just call the external archiver once, and pass all 3 filesnames. This also
means that the call to system() can return non-zero (e.g. Info-zip 'unzip'
will return 2 if any of the files aren't present in the archive, even if
one is) - so ignore this return value from system(). This speeds up bulk
import (e.g. using addfiles.js).

Unfortunately, I couldn't really find a nice cross-platform way to suppress
the unzip "caution: filename not matched" message sent to stderr. That's
a bummer and a little annoying.

Ignore 0-length DIZ files.

Fix observed crash when shutting down services server where the client_t
protocol was pointing to a freed service's protocol description string.

This was the last pointer in client_t and should resolve the last race
conditions (memory ownership issues) with its data members.

This also resolves a small memory leak in getnodeclient() where the last
client "gotten" would have its heap-duplicated protocol string leaked.

Though the FILES.BBS might have filenames with dashes, the filenames actually
have underscores. Consider converting any other valid DOS filename characters
that are not allowed in ISO 9660 filenames as well (but to what?).

More logging of missing and renamed files (e.g. fixed case, dashes replaced
with underscores).

SlyEdit quote line wrapping update: When re-wrapping quote lines, use the quote wrap settings from xtrn.ini, or default to 79 columns, as many terminals are 80 columns wide.

See merge request !434

Eric Oulashin authored 10 months ago and Rob Swindell committed 10 months ago

SlyEdit quote line wrapping update: When re-wrapping quote lines, use the quote wrap settings from xtrn.ini, or default to 79 columns, as many terminals are 80 columns wide.

lastchar() returns a char pointer, not a char.

This fixes issue #751

Strip prepended and trailing slashes.
Convert backslashes to forward slashes.

When setting lib's parent path:
- Auto-fix the sub-directory name case
- Display error when setting lib parent to path that doesn't exist

The iteration variable (p) is created on the stack.

... kind of as I suspected

Walnut Creek and Simtel CD-ROMs usually have this file format which lists the
sub-directories along with descriptions of each (one per line).

Not to be confused with the DIRS.TXT format that has long been exported from
and imported into SCFG.

This is an attempt to make Nelgin happy (issue #749) without writing/reading
an additional settings file.