- Jul 09, 2023
-
-
Rob Swindell authored
Eliminates a SANITIZE build error
-
- Jul 08, 2023
-
-
Rob Swindell authored
Hopefully Cyan agrees that 1.10 was the logical next version number. Hopefully these are the only 2 places where the version is duplicated.
-
Rob Swindell authored
Someone should add IPv6 exempted addresses too Maybe perform a check against ctrl/dnsbl_exempt.cfg too?
-
Rob Swindell authored
Socket.close() always sets the descriptor to -1 which is/would be logged here as an unsigned int (%u) or 4294967295. If this continues to log 4294967295, then a check of descriptor >= 0 would be prudent. And as Cyan said: <Cyan> the IP would be more useful though
-
Rob Swindell authored
Always log (a notice-level log message) when there's a DNSBL match, along with the address it actually resolved to (indicates which list the IP address was found in). No log message otherwise. Note: resolve_ip() doesn't actually support IPv6 yet, so I don't think this IPv6 address parsing/reformatting logic has actually been tested.
-
Rob Swindell authored
Added RBL lookups on connection via DroneDL. See merge request !297
-
-
Rob Swindell authored
-
- Jul 07, 2023
-
-
Rob Swindell authored
JavaScript is lovely at data validation ... not!
-
Rob Swindell authored
Synchronet IRC services uses RAKILL to remove any previouslly See merge request !296
-
-
- Jul 04, 2023
-
-
Deucе authored
I don't believe them, but I'll fix it anyway.
-
Deucе authored
Should fix ASan "crash".
-
Rob Swindell authored
Check size of X11 property before dereferencing as an Atom. This fixes: ==10203==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000065970 at pc 0x5c5834fb8812 bp 0x7819c717c220 sp 0x7819c717c218 READ of size 8 at 0x602000065970 thread T2 (X11 Events) #0 0x5c5834fb8811 in net_wm_state_is_cb ../conio/x_events.c:1541 But I'm not clear when nitems_return (nir) might represent > 8-bit items or how to detect that, so perhaps there's a *better* fix?
-
Rob Swindell authored
Caught be GCC ASan.
-
Rob Swindell authored
This does look like a false positive to me: the if clauses that use fptr appear to only cover the same values as the switch-case statements. But harmless defensive change here.
-
- Jun 29, 2023
-
-
Rob Swindell authored
Updated Tech question pool. Now valid until 6/30/2026 See merge request !295
-
-
Rob Swindell authored
warning: format not a string literal and no format arguments [-Wformat-security] <nelgin> gcc version 9.4.0
-
- Jun 28, 2023
-
-
Deucе authored
The commit just the zero-length behaviour from uninitialized use with possible undefined behaviour to guaranteed undefined behaviour.
-
- Jun 27, 2023
-
-
Deucе authored
It's unlikely this is what Digitalman reported from ASan and UBSan
-
Rob Swindell authored
-
Rob Swindell authored
Fix multiple warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’
-
Rob Swindell authored
This was really just a test to make sure I had Geany successfully reconfigured to no longer auto-strip trailing whitespace. Spoiler: It wasn't.
-
- Jun 26, 2023
-
-
Rob Swindell authored
As Deon pointed out on DOVE-Net::Synchronet Discussion. Thanks!
-
Rob Swindell authored
This macro hasn't done anything meaningful since we stopped using really old versions of Borland compilers (and std libraries) where strerror() returned a string terminated with a line-feed (\n) character.
-
Rob Swindell authored
These should only be used in the sbbs_t methods called by node_thread or event_thread. Any other thread-shared sbbs_t instances should not use these methods since they share a single error description string buffer.
-
Rob Swindell authored
As reported by Deon on DOVE-Net: type 2.2 packet generation was not (since SBBSecho v3.0) setting the origin and destination point values correctly: was leaving the packet type 2.0 date values in these fields. Also, zero-out the reserved bytes in the type 2.2 packet header (don't leave the type 2.0 date values in there). Thanks for the report Deon!
-
- Jun 24, 2023
-
-
Rob Swindell authored
If the oldlen param value is less than one, set to a sane non-zero value (79). Fix issue #576
-
- Jun 18, 2023
-
-
Rob Swindell authored
this is recommended to reliably display the call stack when using the print_stacktrace option.
-
Rob Swindell authored
left shift of 255 by 24 places cannot be represented in type 'int'
-
Rob Swindell authored
<phigz> what would you convert ansi to so it displays right when written out from a .js file? Now, you can use 'ans2asc -esc' for this purpose.
-
- Jun 17, 2023
-
-
Rob Swindell authored
e.g. running '../cleanall.sh' from the src/sbbs3 dir
-
Rob Swindell authored
As reported by GCC 10.2 with FORTIFY=1 and SANITIZE=1
-
Rob Swindell authored
Not sure how I missed this before <shrug>
-
Rob Swindell authored
This should fix the SBBS-MSVC build in CI.
-
- Jun 16, 2023
-
-
Rob Swindell authored
This utility doesn't expand Ctrl-A codes, so just strip them.
-
Rob Swindell authored
The InactivityAlert string is sent as a warning before disconnect when a visible alert (AreYouThere) shouldn't be sent. Defaults to 3 beeps. Remove the content of the NodeActionMultiChat (over-rides the hard-coded default node status) - weird that this was the only node status that reported the user's security level in the default configuration. This has been this way since sbbs v2.30, at least. I think it was to be sure that others could see the age/gender of those they were chatting with. But we have other methods of reporting that in node status now, so we don't need to use this override string to accomplish that.
-