Also make it more clear in the online help that some of the new user values
are also applied to Guest (G-restricted) account logons.

DDFileAreaChooser: Fix for the directory item counts

See merge request !425

DDFileLister: List header line refresh fix - Right border characters were shifted left 1 char (noticeable when the batch add success dialog closed)

See merge request !424

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDFileLister: List header line refresh fix - Right border characters were shifted left 1 char (noticeable when the batch add success dialog closed)

We may want to set NO_LTO for the pipeline...

It's better to have deleted messages without a hash than to hash invalid
message numbers.

This can be used to address a (renumbered?) message base that Kirkman
shared with me with "Invalid Message number" chksmb warnings from hash
entries with message numbers > than the base's last_msg.

These were originally non-ASCII char literals.

substrWithAttrCodes() fix (string was too long by 1 char; in dd_lightbar_menu.js); a couple of small corresponding updates in ddfilelister.js

See merge request !423

substrWithAttrCodes() fix (string was too long by 1 char; in dd_lightbar_menu.js); a couple of small corresponding updates in ddfilelister.js

So KOSTEN means "cost" in German, sort of the opposite of FREE. Maybe
"!KOST" would get the point across?

Older versions of Windows don't (always?) call VDDInitialize(), so we need
to statically initialize the uart struct.

This should address the problem reported by Fzf (FQBBS) via DOVE-Net:

... When using the included SBBSEXEC.DLL, the UART emulation
defaults to base address 0x000 and interrupt 0x0.  The lockups do not occur
when this is left as-is but none of the UART emulation does anything.  Setting
a ComPort in a [UART] section of SVDM.INI or SBBSEXEC.INI does change the I/O
address and IRQ to an expected value.  But this isn't necessary.  The mere
existence of one of those two INI files, even if empty, sets the UART to the
expected default of 0x3F8/IRQ4.  The debug entry is always as follows when left
without any INI file:

[180] SBBS: Virtualizing UART (0x0, IRQ 0)

This bug appears to be caused by commit 9266b997 (1 year ago), where
uart was no longer statically-initialzed and relied on VDDInitialize() to be
called to copy default_uart to the uart struct.

Not sure when the last time these files were used, but it couldn't have been
recent.

And is now a good example of how to write a Synchronet command shell in JS,
though classic_shell.js served its purpose.

Range check return value of console.getnum(), as is done in useredit.cpp.

The user hitting ^C at eithe of the terminal columns or rows prompts would
set that value -1.

(see previous commit/merge)

Don't display "FREE" in file listings for 0 byte files.

When removefcdt() is called for an unknown file uploader, use the new
UnknownUploader text.dat string to display the username and filename.

When prompting to remove credits, include the username from which to remove
the credits.

These usability improvements came from watching Deuce struggle to remove
malicious uploaded-files and credits from (presumably Guest) user. I should
watch sysops manage their BBSes more often.

Artifacts from the 16-bit DOS days where we needed the large or huge
"memory model" to allocate > 64KB of memory.

This is likely also broken classic_shell.js, but nobody should ever
open that file anymore.

DDFileLister: Description search as loadable module now works. Added mention of Ctrl-C to the help screen.

See merge request !422

DDFileLister: Description search as loadable module now works. Added mention of Ctrl-C to the help screen.

Also, it's SyncTERM Cyan, not Syncterm.

Doesn't hurt anything where they were, but Coverity kinda reverse
suggested it.

More documentation of stuff.

DDLightbarMenu: Fix in DrawPartial() for an edge case where it was missing the last character of the menu/menu items in some cases

See merge request !421

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDLightbarMenu: Fix in DrawPartial() for an edge case where it was missing the last character of the menu/menu items in some cases

It causes connections to Mystic BBSs to fail, and assumes the
server is running OpenSSH (or Synchronet, which is purposefully
compatible with OpenSSH).

I love the feature, but it's not good enough for on-by-default.

After 1.2 is released, and I do a proper sftp client, I'll likely
remove the option anyway, and just have a way to upload it on
demand.

sftp_finish() which ends the communication, disables further
commands, and can explicitly be called more than once, and
sftp_end() which frees the state.

This prevents a race around sftp_finish() calls and sftpc_*() calls
which is likely responsibe for various weirdness in SSH connections,
and should fix ticket 135.

This eliminates the hack of using ssh_mutex to protect members of
sftp_state (which has its own mutex).

This doesn't fix the problem of sftp_state itself though.