We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...

If no description is given, just make the default/short description, literally, "No description given" - rather than refusing to add the file.

The goal of this commit is that: only modules that either are part-of sbbs.dll/libsbbs.so or need to link with/use that library, will #include "sbbs.h" and thus be dependent on its subsequent includes (e.g. cryptlib.h, jsapi.h). This should mean extdeps.mk can be trimmed way down.

I also removed CVS keyword/comments and trimmed up the boilerplate copyright notice in modified and added source/header files in this commit.

There is no functional change in behavior in this comment.

I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint, isspace, etc.) when called with out-of-range (e.g. negative) values.

This problem only affects MSVC debug builds, but if you run them (like I do), these things are like little time bombs that can drive you crazy (knocking your board out of service).

The new macros names are bit more descriptive as well.

If jsexec is used for a CGI script and the SBBSCTRL env var was not
set, a warning would be printed (to stderr), even if the -c option
was used to specify the path to the ctrl dir.

get_ctrl_dir() now accepts a boolean argument to specify whether to
print a warning when the default value ("/sbbs/ctrl") is used.
Pass FALSE for jsexec, TRUE for other callers (currently).

this should allow the import of a bare filename list (no descriptions or white-space after each filename required).

not set (or blank), use the default ("/sbbs/ctrl") and print a warning to
stderr. This resolves a FAQ for sysops that struggle with setting the SBBSCTRL
env var, but do have sbbs install in /sbbs or a symlink from /sbbs to where
sbbs is actually installed.

Note: this function is different than the one previously defined in getctrl.c
but never used. If/when we ever really need to support PREFIX, then perhaps
we'll use that one (which copies a string to a buffer).

In *nix builds of addfiles, when adding a file list (e.g. files.bbs), the
case (capitalization) of the filenames is taken literally from the file list,
and that may be incorrect in same cases. Detect the correct case of the
filename and use it when importing into the filebases.

to put in the description (in strftime() format). Can also be used in
combination with '-t' if you want today's date/time instead.
It's not very clear from the help/usage output, but if you specify both -f
(or -F) and -t, you'll *only* get today's date in the description (not both
the file date and today's date).

get_file_diz() was reading the contents of the DIZ/SDI file into a local
variable and not returning it or writing to the database. Poof!
Also, read the existing extended description if there is one, when updating
existing files.

- filenames must begin with an alpha-numeric char. Might want to relax this in
  the future if it's a problem, but generally filenames on BBSes do begin with
  alpha-numeric characters and this will help us to identify an ignore
  "garbage" filenames in listfiles.
- always check if the file actually exists, even when parsing the length of
  the file from the listfile. This will also help us to ignore garbage
  filenames.
- also removed an inexplicable unpadfname() call. Filenames in file lists
  should *not* normally be padded (like "this    .txt") - so I'm not sure why
  this was in there. Perhaps for lists generated from filelist.exe (?). Anyway,
  out of an abundance of caution, removed it. Padded filenames are going away.

types twice - first to see if one matches the requirements. If none match,
then search again just for an extractor matching the file extension.
Modernize the get_file_diz() function a little bit (e.g. return bool).

function.
Constify mycmdstr() arguments.
Removed trailing whitespaces.
No functional changes expected by this commit.

Must read the filebase index *before* comparing the upload date.
Also, implement support for -p when a filename is specified on the command-line
(without -s or a list).

When using this option, the file's timestamp is compared with the stored upload
timestamp. If the file is the same or older than the upload date/time, it is
skipped. I think this is what he was asking for.

always truncated to zero-length.
Also: more use of SAFECOPY.

deepthaw.
Also, if there was only one line in the file listing, nothing would be
imported (now fixed).

I've likely broken something though, so if you see weird behaviour with
extended ASCII, let me know please.

This is *likely* to break the Win32 build and even when the macros are
specified in xpdev, I doubt Microsoft has added support for the 'z' size
specifier used in smblib/smbadd.c we'll likely need a SIZE_T_SIZE macro
that is "z" on C99 systems and "ll" or "64" or whatever it is on Win32.

Or maybe a whole slew of complete SIZE_T macros since the 32/64 but thing
and the max file size thing may actually need the full format specification
to be in the macro... "zu" on C99 platforms and whatever magic Microsoft
needs there.

-- Fixes bug reported by Jon Justvig (Thanks!)

Added HOST and IP keywords to allow restricted access/privileges to/for
specific remote hostnames or IP addresses (wildcards allowed).
All string-argument type ARS keywords (e.g. SHELL, PROT, etc.) now support .can
style wildcards.
The current remote client is now used for protocol, host, and IP ARS checking,
when available, so this requires passing the client pointer around (which
explains why so many files are touched by this change) and takes care of a
long standing to-do item (the user's 'modem' value was used for the PROT
value checking, which was not always correct).

Constified the arguments.
Created exascii_to_ascii_char().
Created ctrl_a_to_ascii_char().
strip_ctrl() and prep_file_desc() now takes 2 args.
strip_ctrl(), strip_exascii() and prep_file_desc() now strdup() the input
string and if the dest arg is NULL, returns the allocated and modified copy.
sbbs_t::bputs() now handles ^AZ.
Change Ctrl-A code message network exporting:
1. ^AL, ^A<, ^A[, and ^A] are always translated to ASCII equivalents.
2. ^AZ will terminate the message body prematurely if found.
3. Ex-ASCII (CP437) chars will be translated to ASCII equivalents (rather than
'*') for "ASCII Only" subs.
For import, don't allow Ctrl-AP or Ctrl-AL.
For SBBSecho:
Added support for specifying a link's address on the command-line (e.g. for
use with -h).
Mail server now strips Ctrl-A codes from message bodies for sending via POP3
or SMTP.

by properly const-ifying the appropriate functions and variables.

Not yet tested on Win32

startup option - we will *always* use the local timezone. If the sysop wants to
use GMT/UTC, they should configure their operating system accordingly.

user name.

We really need a single, unified cmdstr() function. :-(

No more temp files in data or data/temp.
ctrl_dir/../temp (e.g. sbbs/temp) is the new default temp dir.
Each server has its own separately configurable temp dir.
BBS events (e.g. QWK packet processing) now have their own exclusive-use
temp dir (e.g. sbbs/temp/event).
All server threads will attempt to create and verify the validity of their temp dir.
System temp dir is only the default global temp dir for Unix (i.e. /tmp), since
the Windows default temp dir (e.g. C:\DOCUME~1\Rob\LOCALS~1\Temp) is not
particularly friendly or attractive.

chars following space.