When bad packets are detected and renamed to ".bad" files, include the reason
in the new filename (e.g. "ff69453a.src-addr.bad" or "ff69453a.pkt-passwd.bad"
instead of just "ff69453a.bad") to make it easier for a sysop to determine
what to do with the bad packets without having to search through log files
to discover the reason *why* SBBSecho considered the packet to be bad.
This behavior can be disabled if desired by setting EchoCfg->Global->Verbose
Bad Packet Names to "No". Note: the reason used is the *last* reason
detected/logged for a packet to be considered bad; it's possible that there
are multiple reasons that a packet may be considered bad. All reasons will be
logged, but only the last reason is used in the new bad packet filename.

Also added the missing "Delete Packets" option (to EchoCfg->Global). Though
this setting was added in sbbsecho v3.0 (and settable via sbbsecho.ini), it
was never exposed via EchoCfg; I don't think that was intentional. Normally,
you'd always want to leave this set to Yes (the default) to delete processed
packets, but when debugging, it may be desirable to leave the packet files
in place. This what the old sbbbsecho v2 '-x' command-line option used to be
used for (disable the deleting of processed packets).

Moved the Global Settings, EchoMail Settings, and File Paths config menus to
the upper left of the screen in EchoCfg. The placement seemed inconsistent
and erratic, so this is a bit of a cosmetic improvement.

I think this is what nelgin/Keyop was asking for via IRC.

Also a bit more constification and cleared up the legacy sbbs_get_ini_fname()
usage: the hostname argument hadn't be used in a long, long time.

Feature request by Ray Quinn (1:214/23)

CID 174223
CID 174227
CID 174461
CID 174519
CID 229602
CID 319040
CID 319137
CID 319159

This should address issue # 261.
Before April 19, 2016, area-linked nodes were required to be listed as nodes in sbbsecho.ini:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/sbbsecho.c?revision=3.6&view=markup
I'm not sure why the change was made to only require that there be a wildmatch for each area-linked node. So just make it a configuration option. <shrug>

Also removed the trailing "..." for every top level menu item in echocfg.

2 new configuration params: MaxLogSize (default: 10M) and MaxLogsKept (10)

The "EchoLists" help menu only worked when you first enter the sub-menu and would get wiped out by subsequent child-menu help text.

Filled out the "Configuring an EchoList" help text.

Fixed issue seen where deleting an EchoList's Required Key didn't set the "dirty config" flag, so saving of changes was not prompted when exiting (if that was the only change made).

The goal of this commit is that: only modules that either are part-of sbbs.dll/libsbbs.so or need to link with/use that library, will #include "sbbs.h" and thus be dependent on its subsequent includes (e.g. cryptlib.h, jsapi.h). This should mean extdeps.mk can be trimmed way down.

I also removed CVS keyword/comments and trimmed up the boilerplate copyright notice in modified and added source/header files in this commit.

There is no functional change in behavior in this comment.

If jsexec is used for a CGI script and the SBBSCTRL env var was not
set, a warning would be printed (to stderr), even if the -c option
was used to specify the path to the ctrl dir.

get_ctrl_dir() now accepts a boolean argument to specify whether to
print a warning when the default value ("/sbbs/ctrl") is used.
Pass FALSE for jsexec, TRUE for other callers (currently).

Add missing break between Robots and Domains menus. Reported via #synchronet on irc.synchro.net by wkitty42

actually used by SBBSecho currently and is only here for use by BinkIT.

Use the COPYRIGHT_NOTICE macro rather than the build year.

adding 'int' to a string does not append to the string

If an incoming message contains no CHRS/CHARSET control line *and* the message
text contains valid UTF-8 character encodings, set the FTN charset value to
UTF-8 so the message will be displayed/handled accordingly.
I did not add checks for header fields (to/from/subject) - we should probably
auto-detect UTF-8 in those as well, but for now, I don't see messages coming
into FidoNet echoes with UTF-8 in the header fields.
Incremented SBBSecho/EchoCfg version to 3.10.

This requires that the AutoAddSubs=true in sbbsecho.ini (the default) and if
you don't want an area file created/updated with new subs, just set new option
AutoAddToAreaFile=false.
Both of these options default to true which is the same as the previous
behavior: if you have a link that configured to hub for a msg group, any subs
not already in the area list/file will be considered new and added dynamically.
So what's new here is that you can set SBBSecho not to create or update an
area file and SBBSecho will run just fine if no area file exists or contains no
area definitions.
Incremented version to 3.09.

Remember the currently selected option on variable-length menus that might
scroll (using the "bar" var/pointer thing for uifc.list).

linked nodes: UseOutboxes (default: true)

BinkIT will continue to outboxes even when this option is set to false, but
SBBSecho won't place any mail files in the outboxes when this option is set to
true.

For PSI-Jack who was surprised that SBBSecho put mail files into outboxes.
Since it appears BinkD supports both outboxes and normal outbound directories
for linked nodes and BinkIT does as well, this shouldn't really make any
difference - just a sysop preference.

Use "save/restore" uifc.list() mode for "Save Changes" prompt - no need to
leave the prompt visible while saving changes.
Display pop status while saving changes to config file.

CryptSupport (default true), to:
PlainTextOnly (default false).

With this option, it is now possible to support CRAM-MD5 authenication while
not allowing encrypted sessions (inbound or outbound) - not sure why.

settings affect both NetMail and EchoMail import/export.

(when set to Yes).

The default is off (no stripping). Previously, Soft-CRs were always stripped,
but this behavior is now seen as an anachronism as CP437 char 141 is an
important non-English laguage character and used as such in FidoNet msgs.

confusing with 3 bool settings (in the sbbsecho.ini) to represent 4 valid
security requirement levels, so I attempted to simply the menu options to
make it easy for sysops.
BinkpAllowPlainText now defaults to true since the supported encryption method
isn't even an official FidoNet standard, yet.
I also added/updated some online help (F1) help text.
Added an "Exiting" popup (like SCFG) when exiting.

Added version for Bill McGarrity: for each linked-node, a preferred
local address (AKA) can be specified to be used as the source address
when creating packets destined for that linked-node. If no local address
is specified, the previous (best match) logic is used: find an AKA that
has the same zone and net as the destination address, if none found, use
the first address with the same zone.

(defaults to 10 megabytes, "10M").
When SBBSecho starts up, if this minimum amount of free space is not
available in any of the following directories, SBBSecho will display an
error and immediately exit:
- data directory (in SCFG)
- logs directory (in SCFG)
- netmail directory (in SCFG)
- outbound directory (from sbbsecho.ini)
- temp directory
- each linked-node's outbox, if configured

If the sysop runs out of disk space for some reason, at least SBBSecho
won't contribute to the problem.

made their display conditional on mailer-type being set to FLO/BSO.
Added a help menu to the BinkP Settings menu (under Linked Nodes).

(Argus and Mystic's BinkP mailers don't support encryption).