We want to not expand tilde to attributes when there are any attribute codes
in the mnemonics string. The existene of a non-attribute ctrl-a code should
not have prevented the tilde expansion.

Fix for issue #805 reported by Nelgin (thank you)

RIP XOR operation had issues with polylines, boxes, etc. where the
same pixel could be written more than once, resulting in it being
toggled back to the original state.

Also, there were some memory leaks of temporary struct ciolib_pixel
variables.  This is now fixed as well.

Although we've added (in SBBS v3.20) configurable numeric date input/display
formats for the system, the output was still ambiguous for users (e.g.
NN/NN/NN which could be interpretted a number of ways), so I've added an option
to choose "verbal" short date formats to be displayed where possible instead.
The same value separate from the numeric format (whatever the sysop chose) is
used in the verbal date output, but since month name abbreviations are 3
characters, only one separator is used (to keep the output length fixed at 8
characters).

The new "Verbal" short date display format is choosable in the SCFG wizard and
via SCFG->System->Short Date Format.

Both selecting scrollback from the online menu, and viewing the last
scrollback from the main menu were impacted.

Currently, this is a slower way to look-up a text.dat string, but requires no
load/require of text.js and allows for a shorter syntax to get a text.dat
string, i.e. bbs.text("Quit") instead of bbs.text(bbs.text.Quit);

Although the bbs.text() ID lookup is cached, it's only marginally faster than
system.text() ID lookup, which is not cached and about 1/3 the speed of the
other methods of index to string lookup (in the MSVC-Windows build).

... with Servers->Terminal Server->Login Requirements

Updated help text: F5->Ctrl-C, no need to hand-update sbbs.ini when adding
or removing nodes (any more).

DDMsgReader: Sorting of sub-boards when changing to another sub-board (for nelgin). Toggleable behavior to only show sub-boards with new messages in the indexed-mode newscan (for kdi4hw). Internal: Updated for bbs.msg_number and bbs.smb_curmsg being write

See merge request !465

Eric Oulashin authored 5 months ago and Rob Swindell committed 5 months ago

DDMsgReader: Sorting of sub-boards when changing to another sub-board (for nelgin). Toggleable behavior to only show sub-boards with new messages in the indexed-mode newscan (for kdi4hw). Internal: Updated for bbs.msg_number and bbs.smb_curmsg being write

- Attempt to suppress go aheads in both directions.
- Attempt to set binary mode in both directions
- Request the remote echos

These express the assumptions that SyncTERM always makes, so it's
a good idea to tell the remote this.  For systems that don't like
this, there is the Raw "protocol".

When changing between 8 and 16 row fonts in RIP mode, the cursor
start and end was left for the old font size... 16 -> 8 would leave
the cursor one line below the current position, and 8 -> 16 would
leave the cursor in the middle of the cell.

This hacks the vstat deeper to fix up the cursor as well.

Reported by skipperdoodle1947.

This is a code clean-up, no change in functionality

It's possible to have multiple transfer protocols with the same mmemonic, but
with different transfer types supports (which would be weird, but possible).
This allows us to use protnum() to replace a lot of copy/pasted prot looping
and comparing logic throughout sbbs.

Also added a variant of sbbs_t::quit_key() that takes and returns a string
(for easy concatenation to strings of key chars).

If an ANSI sequence spanned multiple recv() calls, it would get
silently dropped if RIP was enabled.

Reported by skipperdoodle1947 (who does awesome stuff)

for use by JS bbs.xtrn_prot_menu() immediately, elsewhere soon.

Also use console.quit_key for localization support

In place of the copy/pasted/ported from C++ version of the same logic

... that the user has access to

So we don't have to reimplement this logic in user_settings.js (or
equivalent) any longer.

Also, fix manpage generation for CMake.

I've forgotten one of these for every RC except the first one for
v1.2. :(

Thanks nelgin.

The amazing Haiku community has redesigned the SyncTERM icons for me!

Unfortunately, I had to remove the default "Synch" icon from ciolib
so that SyncTERM could have its own separate icon. :(

I'm not sure if the msvc builds are using the ciolib.rc file or not,
and I'm not sure how they can add an icon... I'll net DigitalMan sort
that out (sorryish).

MRC: Session stats, mentions, themes, indenting, buffer display, and more

See merge request !464

This was sometimes causing an integer scaled mode (ie: 4×) to be
reduced to very slightly less than that (ie: 3.996255×), making the
window one pixel smaller than it was supposed to be due to integer
truncation.

This could result in being unable to increase the window size using
the Alt+Right-Arrow shortcut and could make new windows one full
size smaller than they needed to be (such as C64 windows).

While we're here, fix the SDL and X11 outputs to trust what
bitmap_drv_init_mode() does.  It was fixed when GDI mode was being
written, but the other drivers weren't updated to take advantage of
that.

Should resolve issue 156 reported by DigitalMan

The ini key value name remains the same: batxfer

<nelgin> batxfer? Why not called it batchxfer ? The extra 2 characters help :)

[shrug]