White-space changes only, exception being the rare insertion of NL before
closing brace (couldn't find the option to disable that behavior).

I excluded some header files (e.g. sbbs.h) since uncrustify seemed to be doing
more harm than good there. I might just end up applying different set of rules
to .h files.

Again, not exhaustive, just the places I found quickly.

1) Initialize saverobot.name since this is checked unconditionally.
   This has a side effect of initializing everything else, but name
   is the only thing that actually matters.
2) Add a bar to the global settings menu.
   Previously, if you scrolled near the bottom and selected an option,
   after changing the option, you would jump up to the last item on
   the initial screen.
3) Fix the AreaMgr Support default value to be the current, not the
   opposite of current.
4) Use the correct variable for EchoMail Relay Filtered Messages
   setting default.

"AreaFix" is a proper product name. Though it's been defunct and unsupported
for decades, we still should not confuse sysops and historians: the general
term for what AreaFix did/does is Area Management, aka Conference Management.

The sbbsecho.ini key names are unchanged and the destination netmail address
for AreaManager requests can still be "AreaFix" (though "SBBSecho" is still
supported as well).

Apparently AreaFix and other area managers assume password never have spaces
in them, so they can support additional arguments following the password in
the AreaFix request.

This change also now disallows setting AreaManager passwords with spaces in
them.

I don't yet support any of the additional AreaFix request options (e.g. -L,
-R, -Q), but am considering it.

A bunch of sprintf() -> snprintf() conversions are included in this commit
(better string buffer security, probably eliminate a Coverity issue or two).

For controlling the UIFC/CIOLIB properties (scaling, modes, etc.)

... rather than calling textmode() after.

This solves the problem of black bars above and below the UIFC window in
echocfg and SCFG on ChromeOS, at least.

This is an attempt to make Nelgin happy (issue #749) without writing/reading
an additional settings file.

The Git commit date/time is more useful information.

*This* is the way. Oops.

This was the auto/default mode before commit 2ca1e4a0

If you really want the VGA aspect ratio, use the '-v41' option.

The old default Win32 console mode is still available via '-iw' option.

Previously, any packets created for unlinked nodes, would always be Type-2
packets and the packet type for newly created nodes (in echocfg->Linked Nodes)
would be Type-2+.

The new DefaultPacketType setting default is 2+, so the only observed
change in behavior will be that packets created for unlinked nodes will also
be type 2+ (by default).

Some additional log detail/adjustment around created/detected packet types.

... in the linked node listing

Win32 GDI mode is also native, so let's be more specific.

Set the CIOLIB window title (so it's not the default "SyncConsole")

So a sysop now has 3 choices for SBBSecho's handling of incoming bad packets:
 - delete them
 - rename them *.bad
 - rename them *.reason.bad (the default)

If SBBSecho is configured to rename bad packets, but the rename fails, the
error is logged (as before) but the packet is not deleted (this is a change
from previous behavior).

Always log the *reason* a pkt was determined bad in the "Bad packet detected"
log message.

When bad packets are detected and renamed to ".bad" files, include the reason
in the new filename (e.g. "ff69453a.src-addr.bad" or "ff69453a.pkt-passwd.bad"
instead of just "ff69453a.bad") to make it easier for a sysop to determine
what to do with the bad packets without having to search through log files
to discover the reason *why* SBBSecho considered the packet to be bad.
This behavior can be disabled if desired by setting EchoCfg->Global->Verbose
Bad Packet Names to "No". Note: the reason used is the *last* reason
detected/logged for a packet to be considered bad; it's possible that there
are multiple reasons that a packet may be considered bad. All reasons will be
logged, but only the last reason is used in the new bad packet filename.

Also added the missing "Delete Packets" option (to EchoCfg->Global). Though
this setting was added in sbbsecho v3.0 (and settable via sbbsecho.ini), it
was never exposed via EchoCfg; I don't think that was intentional. Normally,
you'd always want to leave this set to Yes (the default) to delete processed
packets, but when debugging, it may be desirable to leave the packet files
in place. This what the old sbbbsecho v2 '-x' command-line option used to be
used for (disable the deleting of processed packets).

Moved the Global Settings, EchoMail Settings, and File Paths config menus to
the upper left of the screen in EchoCfg. The placement seemed inconsistent
and erratic, so this is a bit of a cosmetic improvement.

I think this is what nelgin/Keyop was asking for via IRC.

Also a bit more constification and cleared up the legacy sbbs_get_ini_fname()
usage: the hostname argument hadn't be used in a long, long time.

Feature request by Ray Quinn (1:214/23)

CID 174223
CID 174227
CID 174461
CID 174519
CID 229602
CID 319040
CID 319137
CID 319159

This should address issue # 261.
Before April 19, 2016, area-linked nodes were required to be listed as nodes in sbbsecho.ini:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/sbbsecho.c?revision=3.6&view=markup
I'm not sure why the change was made to only require that there be a wildmatch for each area-linked node. So just make it a configuration option. <shrug>

Also removed the trailing "..." for every top level menu item in echocfg.

2 new configuration params: MaxLogSize (default: 10M) and MaxLogsKept (10)

The "EchoLists" help menu only worked when you first enter the sub-menu and would get wiped out by subsequent child-menu help text.

Filled out the "Configuring an EchoList" help text.

Fixed issue seen where deleting an EchoList's Required Key didn't set the "dirty config" flag, so saving of changes was not prompted when exiting (if that was the only change made).

The goal of this commit is that: only modules that either are part-of sbbs.dll/libsbbs.so or need to link with/use that library, will #include "sbbs.h" and thus be dependent on its subsequent includes (e.g. cryptlib.h, jsapi.h). This should mean extdeps.mk can be trimmed way down.

I also removed CVS keyword/comments and trimmed up the boilerplate copyright notice in modified and added source/header files in this commit.

There is no functional change in behavior in this comment.

If jsexec is used for a CGI script and the SBBSCTRL env var was not
set, a warning would be printed (to stderr), even if the -c option
was used to specify the path to the ctrl dir.

get_ctrl_dir() now accepts a boolean argument to specify whether to
print a warning when the default value ("/sbbs/ctrl") is used.
Pass FALSE for jsexec, TRUE for other callers (currently).

Add missing break between Robots and Domains menus. Reported via #synchronet on irc.synchro.net by wkitty42

actually used by SBBSecho currently and is only here for use by BinkIT.

Use the COPYRIGHT_NOTICE macro rather than the build year.

adding 'int' to a string does not append to the string