Fixes issue #398

Paul Hayton (fsxNet admin) had this idea. This seems to do the trick.

It does use the listed IBN (BinkP) address as a fall-back if the INA and ITN
addresses aren't specified, which may not be desireable.
So maybe that should be a command-line option to enable as desired. <shrug>

1) Unreachable return without a lock in sdl_useR_func_ret() (harmless)
2) LOR in handling SDL_USEREVENT
   - vstatlock was obtained inside of win_mutex which should never
     be done... this could (and likely does) result in a deadlock
     when using SDL mode.

New (optional) keys in ctrl/sbbs.ini (with defaults):
[BBS]
DefaultTermWidth=80
DefaultTermHeight=24

This fixes issue (feature request) #491

The default value is the same as the previously hard-coded value: 15 minutes.

Increase this value to prompt the sysop for the system password less frequently, decrease for more frequent.

This fixes issue #407.

The security-related options were really spread around and this menu was
getting very overloaded (the list of Toggle Options had grown huge), so now
most of the content is actually under the new "Security Options" sub-menu.

This does make a bunch of previous instructions/docs slightly out of sync
(e.g. SCFG->System->Security Level Values should now be
SCFG->System->Security Options->Security Level Values), but I think sysops
will still find stuff just fine.

This re-org will allow me to add more options that I've wanted to but needed
better organization and structuring to do so logically and clearly.

Using the memcmp() trick to detect changes in the configuration.

No new settings/option were added in this commit.

Off-by-one bug caused the comparison of only the first 3 chars of the proposed password against "QWE", "ASD", and "!@#" rather than the 4 character pattern match as intended.

These lines should be removed anyway since this can be easily achieved via password.can (as intended), but I couldn't help myself but to fix this ancient bug.

DDMsgReader: As a loadable module, now make use of user# parameter for reading personal email (for the sysop when deleting a user account)

See merge request !254

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: As a loadable module, now make use of user# parameter for reading personal email (for the sysop when deleting a user account)

... not before. This explains why FTP-uploaded actions had a (null) filename.

Requires the latest v3.20a for sytem.matchuserdata() to support deleted and
inactive user record searching.

This is part of the fix for the issue described in issue #513 where the
UEDIT sysop command was falling back (displaying/editing) user #1 because
the sysop-specified user number or alias was not an active user account.

The fallback to display/editing user #1 still happens, but first we try
really hard to find the user that the sysop specified as an argument to
the UEDIT command.

Insert an optional boolean argument to enable a search through deleted and
inactive user records (in addition to active user records). This is part of
the solution to the problem described in issue #513 where the UEDIT sysop
command did not go to a specified user (by alias) automatically, presumably
because the user record was marked as deleted.

Log the characters themselves of ASCII values (between 32 and 126) for com
debug log messages. Still a separate log message/line for every character
(so very chatty/verbose).

This fixes issue (feature request) #510

Fix issue #508

https://support.microsoft.com/en-us/topic/howto-specify-serial-ports-larger-than-com9-db9078a5-b7b6-bf00-240f-f749ebfd913e

Obviously, it needs the be \\.\COM12

This should fix issue #509

<Deuce> So the [previous] change doesn't work with relative paths?

So... support relative UDS paths in this manner (without the "unix:" prefix)

We don't really need the "unix:" prefix now, but just leave that support in
for backward compatibility.

Set Debug=true in the [com] section of sexpots.ini to enable this (and you'll
need to be logging debug-level message as well). For Nelgin.

According to
https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/
it is possible, but I think I'm using an WinSDK that's too old, so let's just
not support this feature on Windows just yet. Define UDS_SUPPORT when
supported.

Resolves a long-standing todo comment and has made wiki.synchro.net page
rendering even faster.

PHP-FPM defaults to creating/listening on UNIX domain sockets.

This resolves gitlab issue #507

Elevate the log level back to ERROR (from WARNING), as this is not an expected
condition and the sysop (me) should be alerted right away. This had previously
be lowered (along with some other log messages) from ERROR to WARNING.

When php-fpm is updated (on Debian, anyway), e.g. from 8.1 to 8.2, a new
etc/php configuration (pool.d) directory was used which set me back to a
default www.conf file that uses Unix domain sockets instead of TCP sockets.

We don't do output translation for PETSCII terminals for CR or LF
chars, so this trick is needed, at least currently, for the NN legacy prompt
to be properly over-written/invisible for CBM/PETSCII terminals.

Updates/fixes to Good Time Trivia questions & answers etc.

See merge request !253

This is just extra paranoia now since the reading of file.ini enforces the value range
8 <-> 65535 now.

Upgrading fromm v3.19 can result in a setting of filename_maxlen=0 in file.ini, so let's
put a special check in place to insure this can't happen (thus preventing any file
uploads). I chose '8' as a kind of arbitrary minimum maximum value (MS-DOS filenames
maxed out at 12 characters), but at least 0 won't be possibly any longer.

As reported on DOVE-Net by Codefenix and confirmed by xbit.

DDMsgReader: When reading or listing messages, either the DEL or BACKSPACE key...

See merge request !252

Move kbincom() to an sbbs_t method.

No functional change here, just getting ready to support input translation for stdio
external programs as an option.

Since v3.19 (the new filebases), when a user FTP-downloaded a file, we failed
to properly find/load that file's record from the filebase (searching for the
file's full path, rather than just the filename), so the code the increments
the file's download counter, notifies the uploader, awards credits, etc. did
not ever execute. This means that FTP-downloads for all files downloaded via
FTP were effectively "free" (and nobody noticed). No error was logged either.

I discovered this while debugging the case of "(null)" filenames in the
action/download MQTT topic messages being published by the FTP server. So
that issue is fixed as part of this commit as well.

Oh, and if this code had executed before, it would have memory-leaked the
file information, so that's fixed too (added call to smb_freefilemem). Ugh.

Be sure to let them select a node even when no nodes are technically "in use".
As requested by Nelgin in IRC (what, no gitlab issue?)

Looks like just a confluence of search/replace errors over the past 19 years,
starting with commit 9ef382e5.