The interactive prompting for terminal capabilities worked fine,
but the default configuration menu settings did not reflect the
user's previous choices and changes they made (e.g. toggle mouse
support or BS/DEL key swap) were not reflected in the menu. Once
logged in, the normal user defaults menu worked as expected. This
is all because term_supports() keyed off of SS_USERON which isn't
set during new user sign-up, so let's key off SS_USERON|SS_NEWUSER
now.

The previous (reverted) change to SAFECOPY would double-resolve the (src)
argument and caused weird side effects.

Again, removes SAFECOPY_USES_SNPRINTF since it was unused.

This reverts commit c0e857c9.

Really just testing to see if gitlab CI will be triggered by this commit.

This fixes the Borland/Windows build of xsdk that broke yesterday.

This reverts commit 64931c47.

The previous method (patching Makefile.in) didn't disable warnings when
building 'jsshell' (e.g. js.cpp).

If debugging build issues, build with VERBOSE=1 to get the very verbose
SpiderMonkey build output again.

'chown' resets Linux capabilities (e.g. cap_net_bind_service=ep), so these
calls reset the earlier bind-capabilities enablement, meaning the auto-setup
feature on Linux-install really never worked?

Resolves CID 434888, not sure why this one didn't show up before.

In a fresh v3.20 install, the legacy stats files don't exist, so don't try
to convert/upgrade them and log errors about it.

malloc(0) returns a usable/freeable pointer on all supported platforms.

This change insures that the scfg_t dynamically allocated arrays are all valid
non-NULL pointers, even if/when the array length is 0. This should resolve
a lot of new(ish) CIDs. Or not. We'll see. :-/

Added a crlf after printing message scan aborted

See merge request !248

Not as flexible with regards to formatting as xpDateTime_to_isoDateTimeStr()
but simpler to use (with a time_t source).

This should resolve (new) CID 434884 and 434885.

Also, remove the SAFECOPY_USES_SPRINTF check/block - nobody enables this.

DDMsgReader: Small change in resetting the terminal attributes before the script exits

See merge request !247

This fixes issue #495.

We need to support the same filename in different directories.

The 'path' key is just an artifact and not normally used when read,
so that was a distraction that apparently confused me previously
and I broke this functionality in commit c44ed79a.

This should fix the issues reported by xbit (XBITBBS) on DOVE-Net.

Also, don't open the file.ini for write-access (unnecessary).

The sub_t.subnum's that were being updated as message areas were being saved to
msgs.ini could not be used as an index into the scfg_t.sub array at this point
(the subnum would be the new index position when the msgs.ini was re-read/loaded)
.

This was not an issue in v3.19 because we just saved the subnum (to msgs.cnf) and
in v3.20, we save the sub's internal code (to msgs.ini) and were using the newly
updated sub_t.subnum to find the corresponding sub_t for that internal code. Since
the subnum is not used now during the save process, no need to update it here
(this reverses part of the commit 11e529d4 from 5 years ago).

This fixes issue #502 - thanks to the irc.synchro.netizens that reported it!

The first argument to system.matchuserdata() in v3.20 is the user.tab field
number, not the user.dat byte-offset that was used in versions of SBBS prior
to v3.20.

These values are synchronized with userfields.h, but I keept the U_ prefix
here (instead of USER_) to maintain compatibility with existing JS scripts.

This is a fix for issue #501 - thanks for the report Eric!

DDMsgReader: Fix for #499 (replying to emails from unknown user)

See merge request !246

IF user hits 'Q' (or whatever the "Quit" key is), set the default protocol
field in the user record to " " (instead of an empty string).
If user hits abort (Ctrl-C), don't make any change to the default protocol.

There's nothing to upgrade if there's no legacy userbase.

A blank download protocol field in a user.dat, when parsed, sets the 'prot' field
of user_t to 0. When writing the record back to the user.dat, this would prematurely
truncate all other fields off the user record (since strings in C are NUL terminated
and we're using sprintf() to format the record and %c specifier for that field).

The fix is to write a ' ' character instead of '\0' if the user_t.prot is '\0'.
As part of this fix, I'm writing a '?' if a user_t.sex is '\0' (not sure if this
is actually possible, but just as insurance). Those are the only 2 single-character
user properties/fields today.

Bug reported/debugged by Al of The Rusty Mailbox (1:153/757.2) - thank you!

This old prompt used to be sent for any login scripts (e.g. QWKnet
via dial-up) that would key off that WWIV-like "name or number"
(NN:) prompt, but was removed (accidentally?) in commit fedabb0b.

Send "NN: " and "PW: " (include the trailing space, just in case), and use
carriage return to move back (and overwrite) rather than 4 backspaces.

DDMsgReader can now optionally convert Y-style MCI attributes to Synchronet attributes.

See merge request !244