'T' command from the reading messages (O)perator menu

Abstraction the twit-list usage.

DDMsgReader: New user option to toggle the message 'replied' character in the email list. Fix for setting help line colors so that the background won't get un-done.

See merge request !370

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: New user option to toggle the message 'replied' character in the email list. Fix for setting help line colors so that the background won't get un-done.

MRC minor tweaks & fixes:

See merge request !369

The user name is better to log than the user number. Include user name in
brackets.

Colons are not legal filename characters on Windows and when virtual hosts are
enabled, the IPv6 address of the server may be used in the access-log filename
so we need to clean that up or errors opening/creating the access-log files
occur.

Merge branch 'dd_msg_reader_personal_email_delete_after_reply_and_fixes_for_vote_status_and_msg_attributes' into 'master'

DDMsgReader: Option to prompt when deleting a personal email replied to & fixes for message attributes & vote status display.

See merge request !368

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Option to prompt when deleting a personal email replied to & fixes for message attributes & vote status display.

MRC Enhancements: Server Stats & additional tweaks

See merge request !367

Keep original header name alongside normalized for now. We should probably switch to using a method to read these values and do normalization there.

Pass 'answer' query value array instead of first element, submitPollAnswers expects an array. Fixes #283 presumably.

Fixes #675 (probably).

"HTTP Logging" replaced in log messages with "Web Server access-logging".

Using new FCLOSE_OPEN_FILE macro to close and NULify open FILE*'s.

Change CLOSE_OPEN_FILE to a do/while(0) to eliminate extraneous semicolon

The first write to a the temporary SBBS_SSJS.*.html file will open the file.
This should reduce the number of 0-byte files left laying around in the the
temp directory, which shouldn't be happening in the first place.

Also:
Fixed bug noticed in temp file clean up loop:  POST data files would *also*
be retained when the DEBUG_SSJS option flag is set.

Also:
Replace some unsafe string operations with safe equivalents.

Happy Thanksgiving Nelgin!

Default: Warning

I'm tired of SSH-related errors that I can't do anything about, filling
my error.log file and mail inbox.

error: expected ‘)’ before string constant

Harumph.

std::atomic's need to be brace-initialized, or else we fail with
"use of deleted function" errors

Odd that MSVC built it just fine.

Include function names. Include host:port in "Unable to connect" error.

And other safety improvements in getsub()

getkeys() could return -1 if user disconnects (and SS_ABORT not set), so this
appears to be a valid bug.

Add comment/question about the use of JS_SetReservedSlot(), for Deuce

getkeys() is actually never (currently) called with a NULL arg, so this
could not actually occur, but better to prepare for that eventuality.

This looks like a case of not following the YAGNI principle.

Unlikely, but valid thread-safety concerns by Coverity

In response to Nelgin's inquiry:
DigitalMan would it be difficult to add login/logoff date/time to these
messages?
Node  2: xxuserxx logged on Telnet
Node  2: xxuserxx  logged off

Now, you can just use @-codes to add that kind of thing to these text.dat
strings.