Don't expand CR->CRLF when in binary mode that was requested locally
(option value is DO, instead of WILL), using new telnet_opt_enabled().

Request binary-transmit mode by default in Telnet server/answer mode.
Set ServerBinary=false in svdm.ini to disable.

This fixes the extra line-feeds in Telnet-server mode.

An option is enabled/supported regardless of which end makes the request, so
the status can be WILL (an ACK to a remote request) or DO (an ACK to a local
request) when an option is enabled.

Resolves issue with SBBS v2.30 not be able to answer an incoming "call".

Attempt to address 2 GCC version 11.2.0 2 warnings reported by Nelgin
‘%s’ directive writing up to 3 bytes into a region of size between 1 and 4097

... in debug print statement (MD5 hast decoded/printed as SHA-1 hash).

Reported by Nelgin running gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1)

Some shells log every character the user types (e.g. 'X' for external programs)
so we need a newline before the logged DOORSCAN line to be parsed correctly.
From Apam (POSITRON)

On Win32, an off_t is 64-bits while a long is still a measly 32-bits.

svdm.ini IpFilterFile can be set to the path/filename of an "ip filter file",
list of IP addresses or patterns (CIDRv4 notation supported) to refuse
connections from.

This is reusing the same IP filter file logic from SBBS, so the same filter
file syntax/rules apply.

Also a bit more constification and cleared up the legacy sbbs_get_ini_fname()
usage: the hostname argument hadn't be used in a long, long time.

I just wanted to reuse findstr() in vdmodem.c and I fell down this hole :-)

findstr.* is new (findstr() related functions moved from str_util)
getctrl.* is now finally the real home of get_ctrl_dir(), moved from str_util
trashcan* functions moved from str_util to scfglib
other scfg_t dependent functions moved from str_util to scfglib

net_addr() appears to be a function that was never created/used (?)

This will definitely break the *nix build, for now.

Also controlled via [modem] CallerID key in svdm.ini fiile.
Reports the connected IP address between the first and second RING result.
Required a fix to reset the ringcount to 0 upon new connection.

Simplified the AT command parsing logic a bit.

This sets the stage for "Caller-ID" support and IP/host filtering (before
sending a "RING" result and requiring an auto-answer or host/BBS software to
send "ATA").

Likely fix for the user.dat open file descriptor leak:
If js_CreateUserObject(cx,parent,cfg,"name",...) is called multiple times
(e.g. before login and after login), the successive calls will reuse the
previously allocated JS object and allocated private data memory. However, the
private data memory (which includes the descriptor of an open user.dat file,
if it has been opened), was always zeroed, even if it was being reused. This
would leak open file descriptor.

So any (pre)login scripts or web scripts that use the "user" object (which
is all zeroed-out before login) and then allows a user to subsequently login,
would leak a file descriptor.

by default, client.ini in the current working directory.
Configurable filename via ClientFile key in the root section of svdm.ini.

Fixed weird character issue from last commit

See merge request !175

Fixed a weird character issue from the last commit, that may have been due
to using a different text editor that changed some characters, possibly due to
character encoding

SlyEdit 1.77: Fix for aborting when trying to access sub-board information when there are no sub-boards

See merge request !174

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

SlyEdit 1.77: Fix for aborting when trying to access sub-board information when there are no sub-boards

Re-init the UART struct in the init routine to avoid confusion when making .ini file changes with older NTVDMs (including NTVDMx64) which don't re-load the VDDs for every invocation.

Added undocumented experimental options -I and -O to enable DOS input and output interception modes in sbbsexec (e.g. to be used possibly with '-h'). Also -M to specify sbbsexec mode value by number (e.g. 3 to enable DOS Input/Output redir).

Added '-n' option to specify node number (probably no real value/need).

Safe string formatting.

When listening, the address family cannot be PF_UNSPEC, so default to PF_INET (IPv4), when not specified.
Not sure why we're setting ai_flags to PF_UNSPEC (copied from syncterm) - that's just 0, but otherwise the PF_ and AI_ flags are not compatible.
Don't set the ai_flags to anything here since they don't seem to change the behavior.

Fix a corner case where an invalid command-mode escape sequence (e.g. "+.+.+") could've been interpreted as valid.

More case-insensitivity in parsing special "number" values (e.g. 'L' for last number).

Default to Telnet mode (not Raw TCP).
Default to unspecific address family (not IPv4).
Case-insensitive "-telnet" and "-raw" option recognition.

To (re)generate git_branch.h and git_hash.h every build

svdm -V and "ATi1" output.

To be more consistent with other Synchronet project and solution files.

So it can be reused for other projects more easily