CID 476253

The 4th enhancement request of issue #674

The other requests look a bit more involved than I'm willing to explore right
now. And Deuce reassigned this back to me. So that's probably all that's going
to be done.

When flushing, set timeouts high, then set zero read timeout
Ensure channel IDs are protected by the ssh mutex
Check channels are open every time though input thread and before sends
Fix various locking errors
Install public key in a background thread

Once a startup race is fixed, this should be good to go!

and before the first response.

DDMsgReader: For indexed mode newscan, default to showing "No new messages" instead of showing the indexed menu if there are no new messages. This can be toggled via a user setting & new configuration option, displayIndexedModeMenuIfNoNewMessages

See merge request !380

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: For indexed mode newscan, default to showing "No new messages" instead of showing the indexed menu if there are no new messages. This can be toggled via a user setting & new configuration option, displayIndexedModeMenuIfNoNewMessages

Go ahead and fix false-positive CID 33482 by adding a NULL check to quotestr()

CID 462234

Even though smb_getmsghdr() just saves and restores the msg.idx_offset value
(not actually using it, but triggering this Coverity issue), this does seem
like better behavior and more consistent with the loadfiles() implementation.

The use from addfiles.js (the -readd option) implies this is what's expected.
And echicken was suprised the 'added' date/time-stamp wasn't udpated.

Nobody's really using this auxdata yet, besides echicken, so no impact for
others.

Don't count read closed channels against "is this the last one?" checks
Fix checking of channel attributes are present.
Fully close readclose channel if it's the last one.

Previously, there were (basically) three states... active, closed,
and writeclosed where writeclosed indicated that a channel close
message was sent, no more writes are allowed, and it's waiting for
the close to be acked.

This adds a readclosed state where we have received a close request
from the remote (and acked it), but have not deactivated the channel
ourselves.

This fixes a race condition where we could select a channel, then,
when we write data to it, we receive a close and the channel becomes
inactive so a new active channel is selected (effectively at random).

This is a bit suboptimal though since we still don't get a
notification when a channel is closed by the remote.  Instead, if
we use more than one channel, we need to periodically make the
channel active for writes and explicitly check if it's closed.

If you initially try private key auth for example, allow retrying
with password auth and vice-versa.  This is needed for reasonable
fallback from private-key auth since we don't know in advance
which will work, and we don't want to disconnect an reconnect.

This takes the guardrails of adding a password.  Previously, it was
ensured that a password was always added immediately after a username.
This is to ensure when using the server for example and stuffing a
list full of all the user/pw pairs, each pw goes with a user.

Instead of returning an error, this now allows adding passwords
without a corrsponding user that won't be used, and there will be
no indication of why.

Death Star mode for this feature is better than not having fallback
in my opinion.

The Global Login Requirements (default: blank) are used for any sever that doesn't have it explicitly set.

This resolves issue #666 (the issue of the beast) for Keyop

(missed as part of previous commit)

e.g. User.downlaoded_file() will now publish to the appropriate MQTT topic and changes to system.node_list[] will get published to MQTT.