DDMsgReader: When reading or listing messages, either the DEL or BACKSPACE key...

See merge request !252

Move kbincom() to an sbbs_t method.

No functional change here, just getting ready to support input translation for stdio
external programs as an option.

Since v3.19 (the new filebases), when a user FTP-downloaded a file, we failed
to properly find/load that file's record from the filebase (searching for the
file's full path, rather than just the filename), so the code the increments
the file's download counter, notifies the uploader, awards credits, etc. did
not ever execute. This means that FTP-downloads for all files downloaded via
FTP were effectively "free" (and nobody noticed). No error was logged either.

I discovered this while debugging the case of "(null)" filenames in the
action/download MQTT topic messages being published by the FTP server. So
that issue is fixed as part of this commit as well.

Oh, and if this code had executed before, it would have memory-leaked the
file information, so that's fixed too (added call to smb_freefilemem). Ugh.

Be sure to let them select a node even when no nodes are technically "in use".
As requested by Nelgin in IRC (what, no gitlab issue?)

Looks like just a confluence of search/replace errors over the past 19 years,
starting with commit 9ef382e5.

A sysop can, and may want to, chat with a user before they succesfully login.

On the node options popup menu, these options weren't visible/available unless
there was a user logged-in, but they're usable and useful even when there
is not a user logged-in.

DDMsgReader: Fix for reading colors from the theme file. Also, removed debug function from dd_lightbar_menu.js

See merge request !251

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Fix for reading colors from the theme file. Also, removed debug function from dd_lightbar_menu.js

DDMsgReader: (Hopefully) improved display of certain ANSI messages

See merge request !250

e.g. "action/hack/smtp login" -> "smtp_login", best practices and all.

e.g. 20230130T171211-480	0	<unknown user>	76.89.231.66	<no name>

the user number name actually *are* known at this stage

Don't give QWKnet accounts the 'M' (email messages per day) exemption by
default as this has been abused by email spammers.

These are security/anti-spam improvements.

This shouldn't be possible during new user sign-up, but there have been ways
to curtail checks and generate user accounts with login names and passwords
that are the same sequence of characters, unfortunately.

Add some handy tips too (querying status, monitoring log output)

This was a bug if the user had set their terminal to swap Delete and Backspace keys while not using a PETSCII terminal.

- Most published messages (besides log entries) have a timestamp (in ISO8601 format) prepended and tab-separated
- The order and number of elements in client messages (list and activities) has been updated, now includes user number
- Server client lists are now published to .../SERVER/client/list
- Server client activities (connect, disconnect, update) are now published to .../SERVER/client/action/#
- Server client count is now published to .../SERVER/client (with the maximum client count, if applicable)
- Server states are now just represented by name (e.g. initializing, ready, stopping, stopped) and not number
- BBS errors are logged to sbbs/BBS/action/error/LEVEL (where LEVEL is the log level name, e.g. "critical" or "error')
- All server hack-attempts, SPAM attempts, logins, logouts, uploads, downloads, are published to sbbs/BBS/action/ACTION/*
- Chat pages are published to sbbs/BBS/action/page/node/#
- New users (on the terminal server) are published to sbbs/BBS/action/newuser
- Posted messages and executed external programs (on the terminal server) are published to sbbs/BBS/action/ACTION/CODE topic
- The event thread started/stopped status is published to .../SERVER/event

Yeah, the wiki will get updated soon to reflect/document all these changes

Removed some debugging lines

See merge request !249

I noticed that the node status displayed by load/presence_lib.js (e.g. used
by exec/nodelist.js) would have (N) for node-message waiting instead of (M)
as is reported in other places (e.g. the node utility, umonitor, sbbsctrl).
So this commit commonizes this behavior.

Now, it's crazy that there are (at least) 3 places that this node status
display is implemented and more things should just use nodestatus() to get
that string, but I'm not solving that copy/pasta issue in this commit.

The interactive prompting for terminal capabilities worked fine,
but the default configuration menu settings did not reflect the
user's previous choices and changes they made (e.g. toggle mouse
support or BS/DEL key swap) were not reflected in the menu. Once
logged in, the normal user defaults menu worked as expected. This
is all because term_supports() keyed off of SS_USERON which isn't
set during new user sign-up, so let's key off SS_USERON|SS_NEWUSER
now.

The previous (reverted) change to SAFECOPY would double-resolve the (src)
argument and caused weird side effects.

Again, removes SAFECOPY_USES_SNPRINTF since it was unused.

This reverts commit c0e857c9.

Really just testing to see if gitlab CI will be triggered by this commit.

This fixes the Borland/Windows build of xsdk that broke yesterday.

This reverts commit 64931c47.