Reusing the variable 'str' here for multiple purposes meant the QWK packet
filename was overwritten by the owner name (the system's BBS-ID):

 ftp> mlsd
 229 Entering Extended Passive Mode (|||2001|)
 150 Opening ASCII mode data connection for MLSD.
 Type=file;Perm=r;UNIX.ownername=VERT; 00index
 Type=cdir;Perm=elc;UNIX.ownername=VERT; /
 Type=file;Perm=r;UNIX.ownername=VERT; VERT

That last file there should have been "VERT.qwk"

Since lock_ssl_cert() is a reader lock, there shouldn't be a whole
lot of contention on aquiring it anyway, and we can thundering herd
our way out of it when it clears.

without locking!  That's chaos!

This ancient bit of was re-writing node.ini files needlessly

Expanded to CRLF or just CR (if strip LFs is enabled).

It is possible for someone to stuff LF-terminated text in a message, so let's
account for that possibility upon export to FTNs where LFs are supposed to be
ignored.

Hopefully help debug why HTTPS isn't working for him

This partially reverts commit 7d26ad80 where a bunch of read() and write()
return value checking was added.

The proper sentinel value here for "no TLS session" is -1, not 0.

This, at minimum, was causing a lot of extraneous calls to destroy_session()
(from js_socket.c's do_js_close()) with an invalid (hopefully, not
otherwise used) cryptlib session ID of 0.

Nothing checks or logs the return value of destroy_session(), but I'd expect
it to be failing ... a lot.

This was broken one year ago in Commit e631451e

Thanks for the report (just now) about this bug Max!

The year is 4 digits, so the offsets aren't the same as the other 2 supported
formats. Doh!

Thanks Max for testing!

... using WIN_FIXEDHEIGHT mode to limit the list height in wizard mode.

I had a solution using a negative width param value to specify a height limit,
but then I saw this code in ulist():
```
	if(mode&WIN_FIXEDHEIGHT) {
		height=api->list_height;
	}
```

something Deuce added for SyncTERM and I don't think I've ever used before.
It works.

This also addresses the addresses with 65535 in them in the new debug-level
log messages "New packet (type x) created for linked-node" .

To complete the request from: Max (WESTLINE)

  Is it possible to do a new dateformat in scfg
  In sweden we using YYYY-MM-DD format as standard.

The default will be '/'.  Technically, any separator is possible by editing
the "date_sep" value in the global section of main.ini.  SCFG allows the
most popular separators: /.- and space.

... and YYYY/MM/DD for birthdate input/display.

Now set in SCFG->System (not toggle options) and stored in the "date_fmt" key
(new) in main.ini. The old sys_misc SM_EURODATE flag is deprecated (but used
to determine the default value of date_fmt when not present).

As requested from: Max (WESTLINE)

  Is it possible to do a new dateformat in scfg
  In sweden we using YYYY-MM-DD format as standard.

This completes the revert of commit c22063f9 from (Jun-2-2016). The Baja
part of that commit was reverted in commit 932fae30 (Nov-15-2016). This
behavior has proven to be surprising and annoying for JS mod developers
(e.g. the yesnobar.js and Nightfox's file searcher/scanner).

If we still need clearing of abort status after running JS "externals",
that should probably be done in exec_xtrn(), not here.

Should calm the clang warnings reported by Deuce:

e.g.
passing 'char *[18]' to parameter of type 'const char **' discards qualifiers in nested pointer types

CID 476253

The 4th enhancement request of issue #674

The other requests look a bit more involved than I'm willing to explore right
now. And Deuce reassigned this back to me. So that's probably all that's going
to be done.

Go ahead and fix false-positive CID 33482 by adding a NULL check to quotestr()

CID 462234

Even though smb_getmsghdr() just saves and restores the msg.idx_offset value
(not actually using it, but triggering this Coverity issue), this does seem
like better behavior and more consistent with the loadfiles() implementation.

The use from addfiles.js (the -readd option) implies this is what's expected.
And echicken was suprised the 'added' date/time-stamp wasn't udpated.

Nobody's really using this auxdata yet, besides echicken, so no impact for
others.

The Global Login Requirements (default: blank) are used for any sever that doesn't have it explicitly set.

This resolves issue #666 (the issue of the beast) for Keyop

(missed as part of previous commit)

e.g. User.downlaoded_file() will now publish to the appropriate MQTT topic and changes to system.node_list[] will get published to MQTT.

The old default Win32 console mode is still available via '-iw' option.

As pointed out by echicken: when setting the "cost" property to any value, the actual
file's cost would be set to 9223372036854776000 regardless of what number was in the
provided file metadata object. Most jsval numbers aren't doubles (they're ints) so
need to use JS_ValueToNumber() to do the proper conversion, regardless of underlying
type.

Noticed the same problem with the "size" property.

Thanks for the tests and report echicken!