Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

Good Time Trivia 1.03: Fixes to score reading & parsing. Q&A files can have more flexible metadata. Added more questions.

Allows for more/better wildcard matching in viewable and testable
file types and download-events (e.g. "tar.gz" or "tar.*").

This solves the "double-dot" problem in some file types/extensions.
An implicit "*." is prepended before the configured file type/extension.

If libarchive couldn't extract a QWK or REP packet, we'd fallback to searching
for a match among the configured extractable file types and if no extension/type
match was found, default to the first configured extractable file type
(even if there wasn't one) which would result in a NULL pointer dereference
and most likely a crash. Instead, if no matching configured extractable
file type is found, just log a warning message and don't continue with the
extraction attempt. With SBBS v3.19+, it's totally valid/legit to have no
extractable file types configured in SCFG and things "just work" (using
libarchive).

For Viewable, Testable, Compressible file types and download events,
the file extension is no longer limited to 3 characters. 15 characters
seemed like "enough".

Similarly, a user's temp/QWK file type preference is also extended from
3 to 15 characters.

This fixes issue #486, but file types such as *.tar.gz (2 dots in the extension)
are still an issue and will be addressed next.

... but the old user.dat fields would still just be 16 chars in size.

Also a strcpy -> SAFECOPY conversion for user tmpext.

I read that 3.1.1 is much more widely supported, but perhaps that was old
info.

When MQTT protocol version is >= 5, just log to the */log topic
(the level is a property).

This means you can't subscribe only to specific log levels when using MQTT v5
so I may re-think this, but I don't want to keep publishing every single log
message twice.

DD lightbar menu fix for navigating with the HOME key with the top item index > 0 & selected item is in the middle of the screen

See merge request !239

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DD lightbar menu fix for navigating with the HOME key with the top item index > 0 & selected item is in the middle of the screen

Value is "http" or "https" depending on if TLS is in use.

This can be useful when debugging issues (e.g. crashes) and an MQTT consuming/logging client wasn't connected at the time.

Yes, someone could have a local hostname of "node". <sigh>

This solves the problem of subscribing to "sbbs/+/+/+" and getting node status in addition to server status (very different formatted messages).

Also include a change for the singular-again "node" topic

If a configuration had *no* command shells, this would have caused a crash here in SCFG.

Also, when selecting the new user command shell, default to the current selection.

Should fix the segfault reported by NeoArata_ in #synchronet

Also include singular/plural error/s in server status messages.

<server>/state is now published directly to the <sever> topic level (the "state" topic goes away).

Moved <bbs-id>/node# topics to <bbs-id>/nodes/# (allows better wild-card subscription per MQTT standards).
Publishing total node count to <bbs-id>/nodes rather than <bbs-id>/node_count

Introduced "publish verbosity" control (defaults to "High") - if you want nice human readable (and sometimes redundant) topic messages, leave this set to "High". To reduce traffic, set to "Low". It's expected that purpose-built Synchronet/MQTT clients should work equally-well with either setting, but when using generic MQTT clients/browser, "high" verbosity is nice. The human-readable node status is only published when "high" verbosity is enabled.

Publishing the BBS name to the <bbs-id> topic, the instance hostname (as configured in sbbs.ini) to the <host> topic. Makes the hierarchy much more clear when using an MQTT browser like MQTT Explorer.

This is more consistent with how these events are logged in a BBS-common log file in data/*.log.

This change also restores the server abbreviation to the error log entries that used to be there until recently.

Makes for a nice node listing with pure-text MQTT clients/tools

Each Synchronet server is now its own MQTT client. This means there's no
longer any MQTT logic in the Synchronet "hosts" (e.g. sbbscon.c, ctrl/*.cpp)
and none needed for SBBS NT services (they'll "just work" with MQTT).

This also means that just about everything (except for nodes, spam and hack)
is now published per-server (in the sbbs/BBS-ID/hostname/server/ topic branch)
and if you want aggregated totals or client lists, you'll have to do that in
your own MQTT client or dashboard.

I also removed the publishing of thread_count and socket_count topics as
they weren't universally supported across all servers and are of questionable
value. They can be added back later if determined to be useful.

A set_state() may be called with SERVER_STOPPED while recycling.

any server "running" is not enough because the server could still be
initializing, re-initializing, or even shutting down.

Aripoll auth wtf

See merge request !238

Technically, the OpenSSL DLLs aren't used right now because I have TLS support
disabled in the 'develop' branch version of mosquitto.dll v2.1.0 that I have
in the repo, but that should soon change.

Fixes issue #476

This solves the problem of any signal (even HUP) ungracefully terminating
sbbs (on *nix) when MQTT was enabled. As reported by Nightfox on IRC.

Should fix the new crash issues reported by Retros via #synchronet on irc.synchro.net