Skip to content
Snippets Groups Projects
  1. Feb 10, 2023
    • Rob Swindell's avatar
      Allow configurable system password timeout · f6b57f98
      Rob Swindell authored
      The default value is the same as the previously hard-coded value: 15 minutes.
      
      Increase this value to prompt the sysop for the system password less frequently, decrease for more frequent.
      
      This fixes issue #407.
      f6b57f98
    • Rob Swindell's avatar
      Overhaul the System Configuration menu - moved all Security Options to submenu · 6c37f34c
      Rob Swindell authored
      The security-related options were really spread around and this menu was
      getting very overloaded (the list of Toggle Options had grown huge), so now
      most of the content is actually under the new "Security Options" sub-menu.
      
      This does make a bunch of previous instructions/docs slightly out of sync
      (e.g. SCFG->System->Security Level Values should now be
      SCFG->System->Security Options->Security Level Values), but I think sysops
      will still find stuff just fine.
      
      This re-org will allow me to add more options that I've wanted to but needed
      better organization and structuring to do so logically and clearly.
      
      Using the memcmp() trick to detect changes in the configuration.
      
      No new settings/option were added in this commit.
      6c37f34c
    • Rob Swindell's avatar
      Fix 30-year-old bug (obvious password patterns) in chkpass() · f11bc546
      Rob Swindell authored
      Off-by-one bug caused the comparison of only the first 3 chars of the proposed password against "QWE", "ASD", and "!@#" rather than the 4 character pattern match as intended.
      
      These lines should be removed anyway since this can be easily achieved via password.can (as intended), but I couldn't help myself but to fix this ancient bug.
      f11bc546
  2. Feb 09, 2023
  3. Feb 08, 2023
  4. Feb 06, 2023
  5. Feb 05, 2023
  6. Feb 04, 2023
    • Rob Swindell's avatar
      Insure that the max (uploaded) filename limit is in the range 8-65535 characters · 6eec2e47
      Rob Swindell authored
      Upgrading fromm v3.19 can result in a setting of filename_maxlen=0 in file.ini, so let's
      put a special check in place to insure this can't happen (thus preventing any file
      uploads). I chose '8' as a kind of arbitrary minimum maximum value (MS-DOS filenames
      maxed out at 12 characters), but at least 0 won't be possibly any longer.
      
      As reported on DOVE-Net by Codefenix and confirmed by xbit.
      6eec2e47
  7. Feb 03, 2023
    • Rob Swindell's avatar
      Move input translation (e.g. for PETSCII) to its own sbbs_t methods · f5f2a7b5
      Rob Swindell authored
      Move kbincom() to an sbbs_t method.
      
      No functional change here, just getting ready to support input translation for stdio
      external programs as an option.
      f5f2a7b5
    • Rob Swindell's avatar
    • Rob Swindell's avatar
      Fix uploader-notification, credit awards, download-counters in FTP downloads · 45b128c0
      Rob Swindell authored
      Since v3.19 (the new filebases), when a user FTP-downloaded a file, we failed
      to properly find/load that file's record from the filebase (searching for the
      file's full path, rather than just the filename), so the code the increments
      the file's download counter, notifies the uploader, awards credits, etc. did
      not ever execute. This means that FTP-downloads for all files downloaded via
      FTP were effectively "free" (and nobody noticed). No error was logged either.
      
      I discovered this while debugging the case of "(null)" filenames in the
      action/download MQTT topic messages being published by the FTP server. So
      that issue is fixed as part of this commit as well.
      
      Oh, and if this code had executed before, it would have memory-leaked the
      file information, so that's fixed too (added call to smb_freefilemem). Ugh.
      45b128c0
  8. Feb 02, 2023
  9. Jan 31, 2023
  10. Jan 30, 2023
  11. Jan 29, 2023
    • Rob Swindell's avatar
      Report the telegram waiting and node-msg waiting statuses separately (M and N) · e5bfd553
      Rob Swindell authored
      I noticed that the node status displayed by load/presence_lib.js (e.g. used
      by exec/nodelist.js) would have (N) for node-message waiting instead of (M)
      as is reported in other places (e.g. the node utility, umonitor, sbbsctrl).
      So this commit commonizes this behavior.
      
      Now, it's crazy that there are (at least) 3 places that this node status
      display is implemented and more things should just use nodestatus() to get
      that string, but I'm not solving that copy/pasta issue in this commit.
      e5bfd553
  12. Jan 28, 2023
    • Rob Swindell's avatar
      New user terminal settings weren't display/settable durin sign-up · ee9c7223
      Rob Swindell authored
      The interactive prompting for terminal capabilities worked fine,
      but the default configuration menu settings did not reflect the
      user's previous choices and changes they made (e.g. toggle mouse
      support or BS/DEL key swap) were not reflected in the menu. Once
      logged in, the normal user defaults menu worked as expected. This
      is all because term_supports() keyed off of SS_USERON which isn't
      set during new user sign-up, so let's key off SS_USERON|SS_NEWUSER
      now.
      ee9c7223
  13. Jan 27, 2023
  14. Jan 25, 2023
  15. Jan 24, 2023
  16. Jan 23, 2023
Loading