DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

See merge request !198

DD file area chooser: Lightbar mode fix for not actually moving to the user's selected directory when directly choosing a directory in their library

I think this is what nelgin/Keyop was asking for via IRC.

If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to open DOSXTRN.RET and log an error when the file doesn't exist (as would be expected).

Broken in commit 082a9fce 3 years ago, the 'H' (highest ranked) message listing was showing the rank of the message (e.g. 1-20) instead of the message number itself.

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

See merge request !197

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

Note: this centering logic does not know the expanded-size of the @-code, so use a fixed-length @-code (e.g. with padding) or use the 'C' @-code format modifier instead.

Fix issue #418

DDMsgReader: Scrolling ANSI and "use strict" improvements

See merge request !195

Also, the logic to check if the user could even view deleted messages (on line 912) was wrong, replace with new method: can_view_deleted_msgs().

As requested by deon (ALTERANT).

Graphic is now only used when using the scrollable interface. Also, when creating the Graphic, now subtracting 1 from the reading area height to avoid making the Graphic one line too tall to avoid unnecessary scrolling.
When saving messages with ANSI codes, Graphic is only used if the message has any ASCII drawing characters. (not sure if this really matters much though).
Also, applied "use strict" and made some changes as necessary.

SlyEidt: Added the ability for the user to choose text color/attribute codes.

See merge request !193

DD file area chooser fix: Listing libraries without first listing directories...

See merge request !194

Synchronet uses "extended normal" mouse reporting for mouse support
(e.g. menu/display file clickable "hot spots"). Many of the JS scripts
that predated Synchronet's own internal mouse support would send their
own mouse-reporting enablement and disablement ANSI sequences and the
terminal could become out of sync with the expectations of the script
(i.e. it would not necessarily disable the mouse modes that had been
set by SBBS before enabling its own preferred mode).

And some scripts (e.g. Synchronet Minesweeper) use a mixture of Synchronet
hotspot support and direct mouse click coordinate reporting, so it was a
mess going between different mouse reporting modes at different times in the
same script.

This all came to light as a result of the fix for issue #412: using mouse
button releases rather than presses to trigger a hotspot.

So mouse_getkey() now has as a separate "release" property it sets in the
return value. Right now its always the opposite of "press", but I can imagine
some mouse tracking modes where movement might be reported with neither a
button press nor release event.

Anyway, Nelgin, give this a try and see if it resolves the issues you were
reporting in IRC with avatar chooser mouse support.

A single source of truth is now used for SBBS's mouse mode (MOUSE_MODE_ON). A JS script doesn't need to know what SBBS's preferred/default mouse-enabled mode flags are, just set to this property to "true". Setting to "false" is the same as setting to MOUSE_MODE_OFF (0).

DD file area chooser fix: Listing libraries without first listing directories within the user's current library (with directory collapsing) works again

For program listings, if the program number is fewer digits than the total
program list count (number of digits), then a carriage return is required
to launch that program. Automate this for the mouse hotspot value, so clicking
Program #1 in a list of 10+ will just run that program and not require the
user to hit the Enter key.

Use the is_valid_subnum() function before using the smb.subnum as an index into (s)cfg.sub[]. Related to the previous committed fix of writemsg(): leaving the global smb.subnum as -1 (INVALID_SUB) after replying to a post via email or netmail, resulting in a crash here.

Fix issue introduced 9 years ago that could cause a crash after replying to a post via email or netmail and then displaying the header of a poll message or a normal message with votes:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f9f9569a317 in sbbs_t::show_msg (this=0x7f9f70c56880,
    smb=0x7f9f70c5e4e0, msg=0x7f9ebadf08b0, p_mode=4, post=0x7f9f18071a24)
    at getmsg.cpp:255
255                                             ,cfg.sub[smb->subnum]->misc&SUB_                                                                              NAME ? useron.name : useron.alias, NET_NONE, NULL);
[Current thread is 1 (Thread 0x7f9ebadf3700 (LWP 23279))]
(gdb) print smb->subnum
$1 = 4294967295
(gdb) bt
#0  0x00007f9f9569a317 in sbbs_t::show_msg (this=0x7f9f70c56880,
    smb=0x7f9f70c5e4e0, msg=0x7f9ebadf08b0, p_mode=4, post=0x7f9f18071a24)
    at getmsg.cpp:255
#1  0x00007f9f957b2aee in sbbs_t::scanposts (this=0x7f9f70c56880, subnum=9,
    mode=2, find=0x7f9ebadf1270 "") at readmsgs.cpp:670
#2  0x00007f9f957bb75a in sbbs_t::scanallsubs (this=0x7f9f70c56880, mode=2)
    at scansubs.cpp:219
#3  0x00007f9f9568c948 in sbbs_t::exec_msg (this=0x7f9f70c56880,
    csi=0x7f9f70c64768) at execmsg.cpp:315
#4  0x00007f9f95683129 in sbbs_t::exec_function (this=0x7f9f70c56880,
    csi=0x7f9f70c64768) at execfunc.cpp:422
#5  0x00007f9f95679450 in sbbs_t::exec (this=0x7f9f70c56880,
    csi=0x7f9f70c64768) at exec.cpp:1199
#6  0x00007f9f9577d742 in node_thread (arg=0x7f9f70c56880) at main.cpp:4364

writemsg() was changing the global smb.subnum and when writing an email or netmail, that subnum value is -1 (since it's not a sub-board) and then later show_msg() is using the smb.subnum as a index into scfg.sub[] when determining if the current user already voted on the message being displayed and then: bang, crash, fall down, go boom.

Simply saving and restoring the smb.subnum when executing an external editor is all that was needed here. And this is the first use of the C++ "auto" keyword in Synchronet!

As described in issue #412, when using extended mouse coordinate (SGR) mode, the mouse button release sequence would be received by the BBS after the hotspot-activated menu option was executed and then that button release sequence possibly passed through to the a child script or program that didn't know how to handle or ignore it.

To resolve this, the BBS now ignores ("eats") the mouse button *press* sequence and only acts upon the mouse button *release* sequence. This is more aligned with how button-clicks work in mouse-control/GUI applications anyway.

As requested. This closes issue #416

Fixed a couple of undefined variable errors.

See merge request !192

Address potential FAQ (issue #415)

In the mouse debug log output. Potentially helpful in debugging mouse related issues when using the SGR mouse reporting mode.

1. Don't enable mouse support if the user's terminal is configured to not
   support it.

2. After calling bbs.receive_file() which displays a menu and uses sbbs's
   internal mouse support, which enables a different mouse reporting mode,
   disable the console.mouse_mode (sbbs's internal mouse support) before
   re-enabling the mouse support for the avatar_chooser's own custom mouse
   mode. Fix fixes issue #414 reported by Nelgin.

3. Fixed a typo in a message displayed to user if avatar upload failed.

With one of the new fields being 64-bit, this lib now requires the updated
File object that supports read/writing 64-bit binary integers too.