Skip to content
Snippets Groups Projects
  1. Sep 20, 2023
    • Rob Swindell's avatar
      Log a critical error message if a node is WFC, but its socket is still in use · 97e74166
      Rob Swindell authored
      This should avoid/work-around issue #630
      
      Nelgin's terminal server log indicated that the node's configuration was being
      reloaded for a new client connection (which doesn't normally/always happen,
      only when there's been a config file change or a node "rerun" requested),
      while there was still a user online using that node. This would explain the
      segfault (configuration fields being freed and reallocated).
      
      The node_socket[] array indicates when a node thread is actively servicing
      a client, so it should contain INVALID_SOCKET for the any node's that WFC.
      If it doesn't, that means something/someone changed the node's status value
      to 0 (WFC) in the node.dab file while the node was still in-use. Let's not
      crash in this case and rather just log the message and give the client the
      next available node (if any).
      97e74166
  2. Sep 18, 2023
  3. Sep 17, 2023
  4. Sep 16, 2023
  5. Sep 15, 2023
  6. Sep 14, 2023
  7. Sep 13, 2023
  8. Sep 12, 2023
    • Rob Swindell's avatar
      Wrap the entire search logic in a try/catch statement · de03c0c6
      Rob Swindell authored
      This should effectively turn script-terminating errors into just warnings and
      thus at least working-around issue #397: the exceptions will be logged as
      warnings intead of errors, but still logged.
      de03c0c6
    • Rob Swindell's avatar
      Allow JS 'user.editor' and '.shell' to be set for non-users (e.g. user #0) · c0370d3c
      Rob Swindell authored
      The request from Nightfox and Accession via DOVE-Net was to be able to set
      a user's external editor even if there's no user logged-in.
      
      These 2 user class properties in the JS object model were a bit special in
      that they *only* wrote to the user database and did not immediately modify
      the in-memory copy of the user_t structure, depending on the re-reading of
      the user.dat/tab file to re-populate the current user_t structure when needed.
      This didn't work if the current user is user #0 (no user).
      
      So, set the current user_t.xedit and user_t.shell accordingly whenever those
      JS properties are assigned a value (a string, the appropriate internal code).
      c0370d3c
  9. Sep 10, 2023
  10. Sep 09, 2023
Loading