- Sep 20, 2023
-
-
Rob Swindell authored
This should avoid/work-around issue #630 Nelgin's terminal server log indicated that the node's configuration was being reloaded for a new client connection (which doesn't normally/always happen, only when there's been a config file change or a node "rerun" requested), while there was still a user online using that node. This would explain the segfault (configuration fields being freed and reallocated). The node_socket[] array indicates when a node thread is actively servicing a client, so it should contain INVALID_SOCKET for the any node's that WFC. If it doesn't, that means something/someone changed the node's status value to 0 (WFC) in the node.dab file while the node was still in-use. Let's not crash in this case and rather just log the message and give the client the next available node (if any).
-
- Sep 18, 2023
-
-
Rob Swindell authored
Some of the errors could be pretty vague since they looked the same and we were depending on the path/file attempted to be opened in the log msg to clue us into what exactly was being attempted. But some of these file paths are sysop-configurable, and they can put unexpected things in there that make it difficult to determine exactly what file was trying to be opened and for what purpose. This should help a little bit.
-
Rob Swindell authored
DD File Lister: Blank out the "# Files Listed" string if used as a loadable module (optional, defaults to true) See merge request !334
-
Rob Swindell authored
DD File area chooser: Bug fix for searching with name collapsing See merge request !335
-
- Sep 17, 2023
-
-
Eric Oulashin authored
-
Eric Oulashin authored
DD File Lister: Blank out the "# Files Listed" string if used as a loadable module (optional, defaults to true)
-
Rob Swindell authored
This allows the calling script to control what the default item is (when the user just hits enter), and not always the first item. Fixes issue #637
-
Rob Swindell authored
-
Rob Swindell authored
DD File Lister 'empty directory' fix, help screen pause, filename searching, etc See merge request !333
-
Eric Oulashin authored
-
- Sep 16, 2023
-
-
Rob Swindell authored
DD area choosers: Header line display fix See merge request !332
-
Rob Swindell authored
Much of the logic ported from sbbs_t methods in con_out.cpp For Nelgin's default_settings.js project
-
Eric Oulashin authored
-
Rob Swindell authored
IIRC, the error was undefined has no properties or split() is not a function, something like that.
-
- Sep 15, 2023
-
-
Rob Swindell authored
As requested by Keyop in #synchrob0yyz
-
Rob Swindell authored
tbz is technically still supported by create_archive(), but without it being included in the supported_archive_formats definition, isn't easily chosen as an option and nobody seems to miss it.
-
Rob Swindell authored
Apparently one was copied from the other and used the same original output file subdirectory name ("upgrade") oops.
-
Rob Swindell authored
I didn't notice that these projects were still being built with a toolset that didn't target WinXP. I might need to update the SDK too.
-
Rob Swindell authored
Also, although not a bug (because we re-read/parse the user's record every menu cycle), don't decrement user.xedit before calling uselect() - just not a good practice to not modify variables unnecessarily. See the corresponding change to exec.cpp, which was a bug.
-
Rob Swindell authored
This bug would leave the user's external editor setting decremented by one if they aborted (with Ctrl-C). Fixes issue #631
-
- Sep 14, 2023
-
-
Rob Swindell authored
e.g. 'jsexec delmsgs mail from joe-blow'
-
Rob Swindell authored
This should be enough for Nelgin to make progress with his user defaults menu script. Not all sections are read and parsed and there will be some extra properties (e.g. "code" in repeated sections that don't normally have that), so the returned objects aren't (yet) suitable for re-writing back to the *.ini files. I also cleaned up some of the exceptions (throwing strings rather than Errors) and removed some empty functions.
-
Rob Swindell authored
-
Rob Swindell authored
Most logs sysops are looking at already have a date/timestamp for each message, so this one ended up with 3 date/timestamps in a single line.
-
Rob Swindell authored
This fixes issue #629
-
- Sep 13, 2023
-
-
Rob Swindell authored
-
Rob Swindell authored
I'll add detailed docs to http://wiki.synchro.net/custom:atcodes soon, but the list is: - TERMTYPE - TERMROWS - TERMCOLS - AUTOTERM - ANSI - ASCII - COLOR - ICE - RIP - PETSCII - SWAPDEL - UTF8 - MOUSE - UPAUSE - SPIN - PAUSESPIN - EXPERT - HOTKEYS - MSGCLS - REMSUBS - FILEDESC - FILEFLAG - AUTOHANG - AUTOLOGON - QUIET - ASKNSCAN - ASKSSCAN - ANFSCAN - EDITOR - SHELL This should (at least mostly) address the issue #629
-
Rob Swindell authored
-
Rob Swindell authored
Apparently if you call mosquitto_publish_v5() with a non-NULL properties pointer, it'll only publish via protocol v5 and doesn't work if you're using protocol v3 connection. Thanks Ree.
-
Rob Swindell authored
... regardless of the configured MQTT protocol version (v5 or v3.x). Also include an MQTT v5 user-property ("time") with the message's origination time/date stamp in ISO-8601 format in all log messages (to both topics). This will at least double the amount of MQTT log traffic to the broker. When MQTT v5 is used, the additional user-properties will increase it even a little more. Is this what you were suggesting Ree?
-
- Sep 12, 2023
-
-
Rob Swindell authored
This should effectively turn script-terminating errors into just warnings and thus at least working-around issue #397: the exceptions will be logged as warnings intead of errors, but still logged.
-
Rob Swindell authored
The request from Nightfox and Accession via DOVE-Net was to be able to set a user's external editor even if there's no user logged-in. These 2 user class properties in the JS object model were a bit special in that they *only* wrote to the user database and did not immediately modify the in-memory copy of the user_t structure, depending on the re-reading of the user.dat/tab file to re-populate the current user_t structure when needed. This didn't work if the current user is user #0 (no user). So, set the current user_t.xedit and user_t.shell accordingly whenever those JS properties are assigned a value (a string, the appropriate internal code).
-
- Sep 10, 2023
-
-
Rob Swindell authored
This should fix issue #626
-
- Sep 09, 2023
-
-
Rob Swindell authored
The node message should be terminated with a newline character. e.g. $ echo "Hey you" | mosquitto_pub -s -t sbbs/VERT/node/1/msg I'm considering the ability to send user message (telegrams) via MQTT too.
-
Rob Swindell authored
Add support for binary frames to websocket service See merge request !330
-
-
Rob Swindell authored
Update node action display on web See merge request !329
-
-
Rob Swindell authored
The reported issue didnt mention JSexec, but I assume that's what was meant by "from the command line". (?) I honestly forgot this script even existed. It's using the old deprecated SMTP SOML command to send a telegram to a user. There are much better ways to do that for the local system (e.g. calling system.put_telegram), but I suspect this script existed since before the JS object model had support for sending user telegrams. Anyway, this was a simple change to fix issue #623, but really this script should probably be rewritten or removed from the repo (we use MSP for sending inter-BBS instant messages these days instead of SMTP/SOML).
-
Rob Swindell authored
sd_notify() is called from other threads (PIDs), so we've been getting syslog warnings abouts this and I hadn't noticed: systemd[1]: sbbs.service: Got notification message from PID 2555007, but reception only permitted for main PID which is currently not known As pointed out by Accession (PHARCYDE) on DOVE-Net.
-