The '-l' (loop) option would cause the JS runtime to be destroyed and
recreated for each new execution of the script, which resulted in memory
leaks in Windows builds (see issue #672 for details). So instead, just
use a single JS runtime here when the -l option is used to prevent that
from happening, though truth be told, that's likely not a normal/common
occurrence. Other apparent JS-related memory leaks (e.g. in the web
server) appear to be of a common concern.

Likely upgrading to a modern libmozjs would also fix this issue, but
we're far short of being able to do that right now.

Other small typos/fixes.

More detail to debug a false-negative SyncBBS-detection result

This solves the problem of detecting a Synchronet (for OS/2) BBS at
telnet://wyseguybbs.mywire.org:2300

That system responds with some control characters (NULs and ^Cs)
before the initial welcome banner, so just strip those out.

This reverts commit cfcff881

... to de-clutter the log

Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines
and that could seriously compromise the security of the Interwebs if those
super-secret passwords were ever leaked!

Previously, any packets created for unlinked nodes, would always be Type-2
packets and the packet type for newly created nodes (in echocfg->Linked Nodes)
would be Type-2+.

The new DefaultPacketType setting default is 2+, so the only observed
change in behavior will be that packets created for unlinked nodes will also
be type 2+ (by default).

Some additional log detail/adjustment around created/detected packet types.

Introduced in commit 0e38cb0f (9 months ago), the first linked-node config
(including packet password!) for the first packed netmail message would be
reused for subsequent packed netmail messages.

Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

Additional debug-level log message when using a packet password for a newly
created packet.

DDMsgReader: New reader-mode operator menu (using the Ctrl-O hotkey), with a (new) option to add the author's name to the twit list

See merge request !372

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: New reader-mode operator menu (using the Ctrl-O hotkey), with a (new) option to add the author's name to the twit list

Since SYMLINK=1 is valid/suggested for install/GNUmakefile, this is a common
mistake that we can catch here.

DDLightbarMenu: Fix to enable wrap navigation again, and fixed a comment about titlebar text

See merge request !371

The Baja PRINT function (used in yesnobar.src/noyesbar.src) calls putmsg()
with P_SAVEATR|P_NOABORT. Without P_NOABORT, putmsg() doesn't display anything
if the global console abort (SS_ABORT) flag is set.

So hitting 'N' or Ctrl-C at one yes/no or no/yes prompt would mean any
immediately subsequent yes/no or no/yes prompt would not be displayed.

Now that we have to require('sbbsdefs.js') for the P_NOABORT definition,
this'll run a little slower. :-(

Enable/conform to "use strict" mode.

Why does a function this small need a comment describing its return value in
the first place? <sigh>

'T' command from the reading messages (O)perator menu

Abstraction the twit-list usage.

DDMsgReader: New user option to toggle the message 'replied' character in the email list. Fix for setting help line colors so that the background won't get un-done.

See merge request !370

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: New user option to toggle the message 'replied' character in the email list. Fix for setting help line colors so that the background won't get un-done.

MRC minor tweaks & fixes:

See merge request !369

The user name is better to log than the user number. Include user name in
brackets.

Colons are not legal filename characters on Windows and when virtual hosts are
enabled, the IPv6 address of the server may be used in the access-log filename
so we need to clean that up or errors opening/creating the access-log files
occur.

Merge branch 'dd_msg_reader_personal_email_delete_after_reply_and_fixes_for_vote_status_and_msg_attributes' into 'master'

DDMsgReader: Option to prompt when deleting a personal email replied to & fixes for message attributes & vote status display.

See merge request !368

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Option to prompt when deleting a personal email replied to & fixes for message attributes & vote status display.

MRC Enhancements: Server Stats & additional tweaks

See merge request !367

Keep original header name alongside normalized for now. We should probably switch to using a method to read these values and do normalization there.

Pass 'answer' query value array instead of first element, submitPollAnswers expects an array. Fixes #283 presumably.