Skip to content
Snippets Groups Projects
  1. Jan 27, 2022
    • Rob Swindell's avatar
      Fix default program section selection · 0deb94c7
      Rob Swindell authored
      Hitting [Enter] is supposed to select the current/default program
      section. Instead, it was quitting. This was apparently broken as
      part of the xtrn_sec.js refactor a year or so ago by/with mlong.
      0deb94c7
    • Rob Swindell's avatar
      Ignore VDD WriteFile() failures if the child process has terminated · 9445866c
      Rob Swindell authored
      If the child process (e.g. door game) has terminated, don't log errors if/when WriteFile() to the mailslot fails. This would be expected as the mailslot is created/owen-by sbbsexec.dll which would also terminate along with the process, thus closing the mailslot. 
      
      Hopefully resolves the errors reported by DesotoFireflite (VALHALLA).
      9445866c
  2. Jan 26, 2022
  3. Jan 25, 2022
  4. Jan 23, 2022
  5. Jan 22, 2022
    • Rob Swindell's avatar
      Add the 'O' (post using real name) restriction flag. · 927a1494
      Rob Swindell authored
      Oh, QWKnet nodes ('Q' restricted accounts) are impacted by this restriction
      since the poster's name isn't taken from the user account anyway.
      927a1494
    • Rob Swindell's avatar
      Handle duplicate names and aliases better · 55be2129
      Rob Swindell authored
      So some cute user (mine@demon.com) created a new user account on Vertrauen with the alias and real name of "Rob Swindell". Funny.
      
      Now, duplicate user aliases are already and always forbidden (even those that just vaguely match an existing alias) - everyone expects those to be unique. And we already forbid new user real names to match an existing user alias (check_name() enforces this and we use that when checking new user real names too), however, nothing prevented a new user account's alias from matching another existing user's real name. And this is a problem:
      
      1. This new/fake user could post a message or send an email/netmail and it would appear to possibly come from the other/original user (we do have options to send mail and post messages using real names)
      
      2. Received email for real names is supported and if enabled, this second account could be used to intercept mail for the original/first account if it was receiving mail for the original/real user's real name.
      
      So disallowing a new user's real name to match an existing alias fixes one problem. 
      However, systems *can* be configured to allow duplicate real names (which is convenient for QWKnet accounts, for example) and so we needed another solution for that problem: meet the 'O' restriction. This restriction flag will prevent a user account from posting messages no sub-boards that require real names. New user accounts that have a duplicate real name (the same as another user account's real name), will automatically be assigned the 'O' restriction flag. Systems that don't allow duplicate real names wouldn't have this issue in the first place.
      
      Scripts that allow the creation of new user accounts might need some updating to match this security logic.
      55be2129
    • Rob Swindell's avatar
      Call can_user_post() rather than manual checks · 9ae0448c
      Rob Swindell authored
      Eliminate some redundant code. Use the userdat lib function provided for this purpose.
      9ae0448c
    • Rob Swindell's avatar
      Remove some commented-out code · cac09153
      Rob Swindell authored
      Posting restrictions are handled one QWK-message at a time (and have been for a long time). No actual change here.
      cac09153
    • Rob Swindell's avatar
      Fix "Username already taken." validation error (could not happen) · 21b8b2c2
      Rob Swindell authored
      The system.check_name() check *also* verifies that the username is not
      already taken, so we must perform the matchuser() check first in order
      to get the appropriate error message here when trying to use an alias
      (username) that's already taken.
      21b8b2c2
    • Rob Swindell's avatar
      Fix issue that prevent "-syslog" option from being used (on *nix) · c6fde03f
      Rob Swindell authored
      Fixed a couple sprintf() buffer overflow warnings/issues.
      c6fde03f
    • Rob Swindell's avatar
      6fde2a0e
  6. Jan 20, 2022
  7. Jan 19, 2022
  8. Jan 18, 2022
Loading