... and USERS.SYS file creation using new C++ type definitions in pcbdefs.hpp.

This mostly fixes issue #366.

PCBOARD.SYS is officially the worst file format ever invented, not just the worst BBS drop file format ever invented. What were these guys smoking?!?

I don't know what reference I used almost 30 years ago when I first implemented PCBOARD.SYS file support, but this time I used the PCBoard v15.3 source code (e.g. sys.c and usersys.c) and even their own code seems to work really hard to conform to these crazy file formats.

USERS.SYS is a little more sane, but not by a lot.

C++ features make this cleaner/easier, but man... there's just so much polish you apply to these turds.

I guess (and hope) that nobody's really running programs that depend on/use these file formats. <shrug>

Just integers right now. And only big or little endian.

Also displays net and aux attribute values when non-zero (weren't displayed
at all with the 'r'ead command previously).

ddfilelister: Now displays extended description in list view if the user has that setting enabled

Closes #363 and #374

See merge request !157

ddfilelister version 2.05 - Now makes use of the user's extended file description setting: If
the user's extended file description setting is enabled, the lister will now show extended file
descriptions on the main screen in a split format, with the lightbar file list on the left and
the extended file description for the highlighted file on the right.
Also, made the file info window taller for terminals within 25 lines high.
This should resolve issue #363 .
This update to ddfilelister also requires the included update to dd_lightbar_menu.js and the
new attr_conv.js.

Functionality replaced with Pascal::String

LORD: Fix crash when exiting aratime igm

See merge request !156

For Trikester (DOVEMOD/BSMNTQQ) 

A visual clue that there was a new navigation method available on some menus (where left/right arrow keys cycle through configured item) was needed. This seems to work nicely.

Passing either WIN_LEFTKEY or WIN_RIGHTKEY in the window "mode" argument enables this new indicator in the upper right of "list" windows. These indicator arrows are mouse-clickable too (translate to the left and right arrow keys).

We had defined uses for all 32 available WIN_* mode bits, so I extended the win mode type from 32 to 64 bits (should this now be called uifc64.c?) :-)

Anyway, it'll be easier to add more WIN_* mode flags as needed later, but I do wonder about JavaScript support (not so great for > 31-bit integers).

Rename len() method to length() to align with std::string.

Note: TEXT_TEXT is actually off-by-one here. I suppose there's no need/use for that value anyway.

Similar to how we can now cycle through the file areas and message areas using left and right arrow keys, do the same for external "online" program sections and program (door) configurations.

/usr/include/c++/v1/iterator:1168:87: error: expected unqualified-id
  ...&& traits_type::eq_int_type(__sbuf_->sputc(__c), traits_type::eof()))
                                                                   ^
/src/sbbs3/../xpdev/filewrap.h:124:21: note:

      expanded from macro 'eof'
        #define eof(fd)                         (tell(fd)==filelength(fd))
  

Does this fix the FreeBSD/clang build?

This was necessary to get to build for MSVC2019 and GCC 8.3.0

Fix issue #372

Ah, that's better. Actually would work correctly on big-endian platforms (should we ever support one) and with way less code.

(e.g. those stored in files, e.g. EXITINFO.BBS).

So I did a search through the code for sizeof.*long and was surprised to find some remaining (harmless) assumptions that a long is 32-bit.

long is 64-bits (8 bytes), not 32-bit on some target platforms (e.g. Linux-x64), so don't assume sizeof(long)==4.

It appears we weren't using these "automatic" integer-size macros anywhere that I can see, so no harm, but might as well fix them.

Also remove BYTE_SWAP_SHORT and BYTE_SWAP_LONG since they're terribly named. Retain the LE/BE_SHORT/LONG macros since we're using them currently in SBBS (e.g. js_file.c).

The default (when no argument to the '-l' option is provided) is to use
the last_few_callers value from the modopts.ini file. This was broken.

If modopts.ini [logonlist] last_few_days is set (to a number), that will
dictate the maximum number of previous days to pull last few callers from
(e.g. set to '0' for previous behavior).

Also, '-l' can now be used with a command-line option (e.g. '-l <num>')
to specify the number of callers to display (overriding the modopts.ini
last_fwe_callers value).

This should address issue (feature request) #371.

If days_ago argument is undefined (as is the case when performing
a "last few callers" query/list), then pull upto the maximum last
number of callers from previous days as necessary.

Part of fix for issue #371

DD File Lister bug fix: Now successfully formats filenames without extensions when listing files.

See merge request !155

Version 2.04 - Bug fix: Now successfully formats filenames without extensions when listing files.
This addresses issue #369.

So I was working on re-writing some of this door file generation code and noticed that the EXITINFO.BBS files generated by SBBS:

1. had a lot of garbage data filling unused string characters (no "harm", but potentially leaking information)
2. had the wrong total file length due to 64-bit logontime (time_t)
3. had the wrong total file length due to writing 19 GosubData elements (instead of 20)

The first and last issues appear to be some of those "forever" (20+ year old) bugs.

So I'm guessing no regularly used door games actually use these portions of the EXITINFO.BBS, so most likely: no harm, no foul. But still, best to fix this before I commit the rewrite.